https://bugzilla.redhat.com/show_bug.cgi?id=859586 --- Comment #3 from MartinKG <mgansser@xxxxxxxx> --- four comments: - PatchY should prefixed with %{name} - use %global instead of %define - %files section contains %defattr if rpm < 4.4 Note: defattr(....) present in %files section. This is OK if packaging for EPEL5. Otherwise not needed See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions - in file section, use %{name} instead of gsm-ussd -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review