[Bug 848142] Review Request: maliit-plugins - Input method plugins

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=848142

--- Comment #1 from Daniel Drake <dsd@xxxxxxxxxx> ---
rpmlint:

maliit-plugins.i686: E: script-without-shebang
/usr/share/maliit/plugins/org/nemomobile/KeyboardUiConstants.js
maliit-plugins.i686: E: script-without-shebang
/usr/share/maliit/plugins/org/nemomobile/EnglishPortrait.qml
maliit-plugins.i686: E: script-without-shebang
/usr/share/maliit/plugins/org/nemomobile/DevStub.js
maliit-plugins.i686: E: script-without-shebang
/usr/share/maliit/plugins/org/nemomobile/meegotouch-keyboard-function-key.svg
maliit-plugins.i686: E: script-without-shebang
/usr/share/maliit/plugins/org/nemomobile/FunctionKey.qml
maliit-plugins.i686: E: script-without-shebang
/usr/share/maliit/plugins/org/nemomobile/meegotouch-keyboard-key.svg
maliit-plugins.i686: E: script-without-shebang
/usr/share/maliit/plugins/org/nemomobile/RussianPortrait.qml
maliit-plugins.i686: E: script-without-shebang
/usr/share/maliit/plugins/org/nemomobile/Popper.qml
maliit-plugins.i686: E: script-without-shebang
/usr/share/maliit/plugins/org/nemomobile/popper.svg
maliit-plugins.i686: E: script-without-shebang
/usr/share/maliit/plugins/org/nemomobile/LandscapeVKB.qml
maliit-plugins.i686: W: no-manual-page-for-binary maliit-keyboard-viewer
maliit-plugins.i686: W: no-manual-page-for-binary maliit-keyboard-benchmark
3 packages and 1 specfiles checked; 10 errors, 2 warnings.

I think you should chmod those "scripts" to 644 because they aren't executable
items.

License: This looks like a BSD-licensed codebase to me.

Will continue the review tomorrow.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]