[Bug 807810] Review Request: ptpd-phc - Precision Time Protocol daemon

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=807810

Jon Stanley <jstanley@xxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |
              Flags|                            |fedora-review+

--- Comment #13 from Jon Stanley <jstanley@xxxxxxxx> ---
OK, this package is APPROVED.

One minor nit that you might want to fix in the systemd unit file though -
there's no way to configure in there. I would add an EnvironmentFile and use
something like /usr/bin/ptpd2 $OPTIONS as the ExecStart.

But the admin can override the unit file if he wants to as well, so I wouldn't
think that this would be a blocker, more of a style thing.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]