https://bugzilla.redhat.com/show_bug.cgi?id=807810 --- Comment #10 from Josh Boyer <jwboyer@xxxxxxxxxx> --- (In reply to comment #9) > Issues: > [!]: MUST Each %files section contains %defattr if rpm < 4.4 > Note: defattr(....) present in %files section. This is OK if packaging > for EPEL5. Otherwise not needed > See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions > > The package seems slightly schizophrenic in this regard :). I think that it > would be useful on EPEL5, but it's half there and half not. It has a > %defattr, but no BuildRoot. Pick one or the other (and I'd suggest the EPEL5 > compatible one :D) I have no interest in doing anything with EPEL5 at all. Ever. If someone wishes to co-maintain this package on that branch then they can fix that up on the branch. > [!]: MUST Package contains systemd file(s) if in need. > > This is a daemon, and there's no systemd unit packaged for it. I'll look into this. > [!]: MUST Changelog in prescribed format. > The changelog lacks versioning info. Erm. Right. > Also, fix the rpmlint warnings about the non-standard group (I think it's > looking for 'System Environment/Daemons' here. OK. > I noted a lack of documentation or default config as well, though the help > output is relatively sane. Yes, well upstream lacks that. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review