https://bugzilla.redhat.com/show_bug.cgi?id=807810 --- Comment #8 from Josh Boyer <jwboyer@xxxxxxxxxx> --- (In reply to comment #6) > For example from one of my packages: > > # Upstream does not provide tarballs. > # To generate: > # git clone > git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/trace-cmd.git > # cd trace-cmd > # git archive --prefix=trace-cmd-%%{version}.%%{checkout}/ -o > trace-cmd-%%{version}.%%{checkout}.tar.gz %%{git_commit} I like it. Stole it blatantly. > Secondly, the standard %{optflags} aren't used. In the same patch where you > drop the kernel includes, you could just as easily add $(CFLAGS) to the > Makefile and do make CFLAGS=%{optflags} > > Thirdly, the debuginfo that is generated is useless - the binary is compiled > without -g. Patch wasn't needed to fix these two. CFLAGS is already specified in the make file and I can just pass CFLAGS="%{optflags} -DUSE_LINUX_PHC" and it covers both since optflags contains -g. Updated: Spec URL: http://jwboyer.fedorapeople.org/pub/ptpd-phc.spec SRPM URL: http://jwboyer.fedorapeople.org/pub/ptpd-phc-2.1.0-0.1.20120921gitecca20.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review