[Bug 858380] Review Request: Gluegen2 - Java/JNI glue code generator to call out to ANSI C

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=858380

gil cattaneo <puntogil@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |puntogil@xxxxxxxxx
              Flags|                            |fedora-review?

--- Comment #5 from gil cattaneo <puntogil@xxxxxxxxx> ---
hi
take this review ...?

Ignore this "issue"
[!]: MUST Header files in -devel subpackage, if present.
the header file are not usefull for developing, only used for build this
package

please fix %changelog
-* Mon Sep 20 2012 Clément David <c.david86@xxxxxxxxx> - 2.0-0.2.rc10
+* Mon Sep 19 2012 Clément David <c.david86@xxxxxxxxx> - 2.0-0.2.rc10
 - Add javadoc subpackage
 - Provide maven pom files

and 
gluegen2-commons.noarch: W: dangling-symlink
/usr/share/gluegen2-commons/make/lib/antlr.jar /usr/share/java/antlr.jar
gluegen2-commons.noarch: W: dangling-symlink
/usr/share/gluegen2-commons/make/lib/junit.jar junit.jar

can you add (or patch) in gluegen-properties.xml

and remove 
build-jar-repository -s -p make/lib/ antlr junit

sed -i
's|classpath="${gluegen.root}/make/lib/cpptasks.jar|classpath="/usr/share/java/cpptasks.jar|'
make/gluegen-cpptasks.xml
sed -i
's|value="${gluegen.root}/make/lib/antlr.jar|value="/usr/share/java/antlr.jar|'
make/gluegen-properties.xml
sed -i
's|value="${gluegen.root}/make/lib/junit.jar|value="/usr/share/java/junit.jar|'
make/gluegen-properties.xml
sed -i 's|value="${ant.home}/lib/ant.jar|value="/usr/share/java/ant.jar|'
make/gluegen-properties.xml
sed -i
's|value="${ant.home}/lib/ant-junit.jar|value="/usr/share/java/ant/ant-junit.jar|'
make/gluegen-properties.xml

should be resolve these 2 warning

fix this also
[!]: MUST Javadoc subpackages have Requires: jpackage-utils

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]