Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: jflex-1.3.5-2jpp - Fast Scanner Generator https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227070 pcheung@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|pcheung@xxxxxxxxxx |mwringe@xxxxxxxxxx ------- Additional Comments From pcheung@xxxxxxxxxx 2007-02-13 11:33 EST ------- (In reply to comment #2) > (In reply to comment #1) > > ... > > X correct buildroot > > - should be: > > %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) > done > Thanks. > > * if %{?dist} is used, it should be in that form (note the ? and % > > locations) There's an extra . before %{?dist} > > X license text included in package and marked with %doc > > COPYRIGHT missing from %doc > done > It's now in the doc subpackage, but I think it should stay in the main package with a %doc flag in the %files section. > > ... > > X specfile is legible > > - Get rid of Vendor and Distribution tag > done > Thanks > > - Source0 should be: http://downloads.sourceforge.net/jflex/jflex-1.3.5.tar.gz > done Thanks > > > - Fix release 2jpp.1%{?dist} > done > Please note no . after 1. > > ... > > X make sure lines are <= 80 characters > > line 89 is longer than 80 characters > done > Great > >... > > * run rpmlint on the binary RPMs > > W: jflex non-standard-group Development/Libraries/Java > > W: jflex wrong-file-end-of-line-encoding /usr/share/doc/jflex-1.3.5/COPYRIGHT > > W: jflex uncompressed-zip /usr/share/java/jflex-1.3.5.jar > > W: jflex-javadoc non-standard-group Development/Documentation > > W: jflex-javadoc dangerous-command-in-%post rm > > W: jflex-javadoc dangerous-command-in-%postun rm > No warnings or errors other than about groups (which can be safely ignored) > > New spec file can be found here: > https://mwringe.108.redhat.com/files/documents/175/209/jflex.spec > > New srpm can be found here: > https://mwringe.108.redhat.com/files/documents/175/210/jflex-1.3.5-2jpp.1.fc7.src.rpm rpmlint now gives: W: jflex non-standard-group Development/Libraries/Java W: jflex non-standard-group Development/Libraries/Java W: jflex incoherent-version-in-changelog 0:1.3.5-2jpp.1 0:1.3.5-2jpp.1. W: jflex uncompressed-zip /usr/share/java/jflex-1.3.5.jar W: jflex-javadoc non-standard-group Development/Documentation -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review