[Bug 847268] Review Request: girara - Simple user interface library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=847268

Mario Blättermann <mario.blaettermann@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |mario.blaettermann@xxxxxxxx
                   |                            |m
              Flags|                            |fedora-review?

--- Comment #7 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4499564

$ rpmlint -i -v *
girara.src: I: checking
girara.src: I: checking-url http://pwmt.org/projects/girara/ (timeout 10
seconds)
girara.src: I: checking-url
http://pwmt.org/projects/girara/download/girara-0.1.3.tar.gz (timeout 10
seconds)
girara.i686: I: checking
girara.i686: I: checking-url http://pwmt.org/projects/girara/ (timeout 10
seconds)
girara.x86_64: I: checking
girara.x86_64: I: checking-url http://pwmt.org/projects/girara/ (timeout 10
seconds)
girara-debuginfo.i686: I: checking
girara-debuginfo.i686: I: checking-url http://pwmt.org/projects/girara/
(timeout 10 seconds)
girara-debuginfo.x86_64: I: checking
girara-debuginfo.x86_64: I: checking-url http://pwmt.org/projects/girara/
(timeout 10 seconds)
girara-devel.i686: I: checking
girara-devel.i686: W: no-dependency-on girara/girara-libs/libgirara
girara-devel.i686: I: checking-url http://pwmt.org/projects/girara/ (timeout 10
seconds)
girara-devel.i686: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

girara-devel.x86_64: I: checking
girara-devel.x86_64: W: no-dependency-on girara/girara-libs/libgirara
girara-devel.x86_64: I: checking-url http://pwmt.org/projects/girara/ (timeout
10 seconds)
girara-devel.x86_64: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

girara.spec: I: checking-url
http://pwmt.org/projects/girara/download/girara-0.1.3.tar.gz (timeout 10
seconds)
7 packages and 1 specfiles checked; 0 errors, 4 warnings.


No problem that the -devel package doesn't contain documentation, because it
depends on the libs ... should depend on it:

(In reply to comment #4)
> The -devel package must depend on the main package in any case:
> 
> Requires:       %{name}-libs%{?_isa} = %{version}-%{release}

OK, we don't have a lib* or -libs package, that's why it has to be:
Requires:       %{name}%{?_isa} = %{version}-%{release}


As already mentioned, either confirm that you want to provide it for el5 or
remove the obsolete stuff.


No further objections. Once you provide new spec and srpm, I will do a full
review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]