Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: objectweb-anttask-1.3.2-1jpp - ObjectWeb Ant task https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227091 pcheung@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|pcheung@xxxxxxxxxx |tbento@xxxxxxxxxx ------- Additional Comments From pcheung@xxxxxxxxxx 2007-02-13 10:18 EST ------- (In reply to comment #2) > (In reply to comment #1) > > MUST: > > X correct buildroot > > - should be: > > %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) > > Fixed. > Great. > > * rpmlint on <this package>.srpm gives no output > > W: objectweb-anttask non-standard-group Development/Java > > This warning can be ignored. > > > W: objectweb-anttask unversioned-explicit-provides owanttask > > Fixed. > The provides should be (without <): Provides: owanttask = %{epoch}:%{version}-%{release} > > W: objectweb-anttask rpm-buildroot-usage %prep rm -rf $RPM_BUILD_ROOT > > Fixed. Great. > > > W: objectweb-anttask mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 37) > > Fixed. > Great > > X Vendor tag should not be used > > Fixed. > > > X specfile is legible > > - Requires jpackage-utils in post and postun javadoc > > Fixed. > > > - Get rid of Vendor and Distribution > > Fixed. > > > - Fix Release tag > > Fixed. > > > - Fix Source0: > > http://download.fr2.forge.objectweb.org/monolog/ow_util_ant_tasks_1.3.2.zip > > Fixed. > > > - When adding the gcj bits, BuildArch: noarch should be removed > > > X make sure lines are <= 80 characters > > line 80 is longer than 80 characters > > Fixed. > Since with_bootstrap option is added, you'll need to define a value for the variable. I'll check the following when the spec file is updated, and rpms rebuilt from that spec file. > > * run rpmlint on the binary RPMs > > W: objectweb-anttask non-standard-group Development/Java > > Ignoring this warning. > > > W: objectweb-anttask incoherent-version-in-changelog 0:1.3.2-2jpp 0:1.3.2-1jpp > > Fixed. > > > W: objectweb-anttask no-documentation > > Fixed. > > > W: objectweb-anttask-javadoc non-standard-group Development/Documentation > > Fixed. > > i> W: objectweb-anttask-javadoc dangerous-command-in-%post rm > > Fixed. > > > W: objectweb-anttask-javadoc dangerous-command-in-%postun rm > > Fixed. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review