[Bug 857524] Review Request: python-django-federated-login - Provides federated logins to django projects

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=857524

Toshio Ernie Kuratomi <a.badger@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |a.badger@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |a.badger@xxxxxxxxx
              Flags|                            |fedora-review+

--- Comment #5 from Toshio Ernie Kuratomi <a.badger@xxxxxxxxx> ---
ba80c4b0b97f1b53a306e6954d072f67e652f03d2924353a62e609e2c3d7928a 
django-federated-login-0.3.0.tar.gz

APPROVED

Good:
* Source matches upstream
* Package name follows naming guidelines
* License is MIT in spec and code
* license file included
* Spec file is legible
* No locale files
* Not a C library
* No bundled libraries
* Not relocatable
* Macros used consistently
* Code not content
* No GUI application
* All filenames are UTF-8
* No scriptlets used
* builds in koji
* Owns directories it creates and nothing more
* Permissions on files set properly

* rpmlint
python-django-federated-login.noarch: W: spelling-error Summary(en_US) logins
-> losing, loins, lo gins
python-django-federated-login.noarch: W: spelling-error %description -l en_US
pre -> per, ore, pee
python-django-federated-login.noarch: W: spelling-error %description -l en_US
backend -> backed, back end, back-end
2 packages and 0 specfiles checked; 0 errors, 6 warnings.

These all make sense in the context of the package.  Ignorable.


Note:
* Package currently has no test suite so currently the %check section is a
no-op
  No harm in having it though.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]