https://bugzilla.redhat.com/show_bug.cgi?id=819951 Michel Alexandre Salim <michel+fdr@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(walters@xxxxxxxxx | |m) --- Comment #13 from Michel Alexandre Salim <michel+fdr@xxxxxxxxxxxx> --- Several problems need fixing -- please consult the list below. Will try and do functional testing while these are addressed. Package Review ============== Key: - = N/A x = Pass ! = Fail ? = Not evaluated ==== C/C++ ==== [x]: MUST Header files in -devel subpackage, if present. [x]: MUST Package does not contain any libtool archives (.la) [x]: MUST Package does not contain kernel modules. [x]: MUST Package contains no static executables. [!]: MUST Rpath absent or only used for internal libs. Note: See rpmlint output [!]: MUST Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in non-devel package (fix or explain):ostree-2012.9-1.fc17.x86_64.rpm : /usr/lib64/ostree/libostree.so ==== Generic ==== [x]: EXTRA Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [!]: EXTRA Spec file according to URL is the same as in SRPM. Spec file is still for .8, not for .9 [x]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: MUST %build honors applicable compiler flags or justifies otherwise. [x]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [!]: MUST Package contains no bundled libraries. Can the package be built against the system glib and libsoup, instead of embedding them? [!]: MUST Changelog in prescribed format. Changelog is missing entirely (uncovering a bug in fedora-review so this turns out to be a useful problem) [x]: MUST Sources contain only permissible code or content. [!]: MUST Each %files section contains %defattr if rpm < 4.4 Note: defattr(....) present in %files section. This is OK if packaging for EPEL5. Otherwise not needed [x]: MUST Macros in Summary, %description expandable at SRPM build time. [-]: MUST Package contains desktop file if it is a GUI application. [!]: MUST Development files must be in a -devel package [x]: MUST Package requires other packages for directories it uses. [x]: MUST Package uses nothing in %doc for runtime. [x]: MUST Package is not known to require ExcludeArch. [x]: MUST Permissions on files are set properly. [!]: MUST Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/lib64/ostree [x]: MUST Package complies to the Packaging Guidelines [x]: MUST Spec file lacks Packager, Vendor, PreReq tags. [!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf is only needed if supporting EPEL5 [-]: MUST Large documentation files are in a -doc subpackage, if required. [!]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [!]: MUST License field in the package spec file matches the actual license. Should be LGPLv2+ and GPLv2+ and BSD Note: Checking patched sources after %prep for licenses. Licenses found: "LGPL (v2 or later)", "GPL (v2 or later)", "LGPL (v2 or later) (with incorrect FSF address)", "*No copyright* LGPL (with incorrect FSF address)", "BSD (3 clause)", "LGPL", "LGPL (v2.1 or later) (with incorrect FSF address)", "GPL (v2 or later) (with incorrect FSF address)", "LGPL (with incorrect FSF address)", "LGPL (v2.1 or later)" For detailed output of licensecheck see file: /home/michel/sources/fedora/projects/FedoraReview/src/819951-ostree/licensecheck.txt [x]: MUST Package consistently uses macro is (instead of hard-coded directory names). [x]: MUST Package is named using only allowed ascii characters. [x]: MUST Package is named according to the Package Naming Guidelines. [x]: MUST Package does not generate any conflict. Note: Package contains no Conflicts: tag(s) [x]: MUST Package obeys FHS, except libexecdir and /usr/target. [-]: MUST If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: MUST Package must own all directories that it creates. [x]: MUST Package does not own files or directories owned by other packages. [x]: MUST Package installs properly. [x]: MUST Package is not relocatable. [x]: MUST Requires correct, justified where necessary. [x]: MUST Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. [x]: MUST Spec file is legible and written in American English. [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [-]: MUST Package contains systemd file(s) if in need. [x]: MUST File names are valid UTF-8. [x]: MUST Useful -debuginfo package or justification otherwise. [x]: SHOULD Reviewer should test that the package builds in mock. [x]: SHOULD Buildroot is not present Note: Unless packager wants to package for EPEL5 this is fine [!]: SHOULD Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean is needed only if supporting EPEL5 [-]: SHOULD If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: SHOULD Dist tag is present. [x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [?]: SHOULD Package functions as described. [x]: SHOULD Latest version is packaged. [x]: SHOULD Package does not include license text files separate from upstream. [x]: SHOULD SourceX tarball generation or download is documented. [x]: SHOULD SourceX / PatchY prefixed with %{name}. [x]: SHOULD SourceX is a working URL. [-]: SHOULD Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: SHOULD Package should compile and build into binary rpms on all supported architectures. [!]: SHOULD %check is present and all tests pass. [!]: SHOULD Packages should try to preserve timestamps of original installed files. Should probably override with INSTALL='install -p -c' [x]: SHOULD Spec use %global instead of %define. Issues: [!]: MUST Each %files section contains %defattr if rpm < 4.4 Note: defattr(....) present in %files section. This is OK if packaging for EPEL5. Otherwise not needed See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions [!]: MUST Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/lib64/ostree See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles [!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf is only needed if supporting EPEL5 See: None [!]: MUST Rpath absent or only used for internal libs. Note: See rpmlint output See: http://fedoraproject.org/wiki/Packaging/Guidelines#Beware_of_Rpath [!]: SHOULD Packages should try to preserve timestamps of original installed files. Should probably override with INSTALL='install -p -c' Rpmlint ------- Checking: ostree-debuginfo-2012.9-1.fc17.x86_64.rpm ostree-2012.9-1.fc17.x86_64.rpm ostree-2012.9-1.fc17.src.rpm ostree-debuginfo.x86_64: E: no-changelogname-tag ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/EMBEDDEPS/include/glib-2.0/gio/gsocketconnection.h ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/gio/gapplicationcommandline.c ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/gio/gapplicationcommandline.h ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/gio/gactiongroupexporter.h ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/gio/gunixfdlist.h ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/gio/gactionmap.h ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/gio/gactiongroup.h ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/gio/gactiongroup.c ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/gio/gactionmap.c ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/gio/gremoteactiongroup.c ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/EMBEDDEPS/include/glib-2.0/glib/gthread.h ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/gio/gsocketclient.h ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/EMBEDDEPS/include/glib-2.0/glib/gcharset.h ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/gio/gthreadedsocketservice.h ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/glib/gunicode.h ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/gio/gsocketservice.c ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/gio/gsocketservice.h ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/glib/gshell.h ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/gio/gthreadedsocketservice.c ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/gio/gsocketcontrolmessage.h ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/gio/gmenuexporter.c ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/gio/gapplication.c ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/gio/gapplication.h ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/gio/gremoteactiongroup.h ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/glib/gmarkup.h ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/EMBEDDEPS/include/glib-2.0/glib/gerror.h ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/glib/gmarkup.c ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/glib/gunibreak.c ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/glib/gspawn.h ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/gio/gsimpleactiongroup.c ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/gio/gsimpleactiongroup.h ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/gio/gsocketconnection.h ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/gio/gactiongroupexporter.c ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/gio/gsimpleaction.c ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/gio/gsimpleaction.h ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/glib/gthreadprivate.h ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/glib/gfileutils.h ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/glib/gerror.h ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/glib/gstdio.c ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/glib/gunicollate.c ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/glib/gfileutils.c ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/EMBEDDEPS/include/glib-2.0/glib/gspawn.h ostree-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/libsoup/libsoup/soup-cookie.c ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/EMBEDDEPS/include/glib-2.0/glib/gunicode.h ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/glib/gthread.h ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/gio/gaction.c ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/gio/inotify/inotify-missing.h ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/gio/gmenu.c ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/gio/gaction.h ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/gio/gmenu.h ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/gio/inotify/inotify-path.h ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/gio/inotify/inotify-path.c ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/glib/gunidecomp.c ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/EMBEDDEPS/include/glib-2.0/glib/gfileutils.h ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/gio/inotify/inotify-helper.h ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/gio/inotify/inotify-helper.c ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/gio/gdbusmenumodel.c ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/gio/gdbusmenumodel.h ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/glib/gshell.c ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/EMBEDDEPS/include/glib-2.0/glib/gkeyfile.h ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/gio/gmenumodel.h ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/gio/gmenumodel.c ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/gio/inotify/inotify-sub.h ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/gio/inotify/inotify-sub.c ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/src/daemon/ot-daemon.c ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/glib/gspawn.c ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/gio/gdbusactiongroup.c ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/gio/gdbusactiongroup.h ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/glib/gcharset.h ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/glib/gatomic.c ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/gio/inotify/inotify-kernel.h ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/gio/inotify/inotify-kernel.c ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/gio/gunixcredentialsmessage.h ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/glib/gkeyfile.h ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/gio/gsocketlistener.h ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/glib/gkeyfile.c ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/glib/gstdio.h ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/glib/gtimezone.h ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/glib/glib-init.c ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/glib/glib-init.h ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/EMBEDDEPS/include/glib-2.0/glib/gmarkup.h ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/gio/gtcpwrapperconnection.h ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/gio/gtcpconnection.h ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/EMBEDDEPS/include/glib-2.0/gio/gsocketclient.h ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/gio/inotify/inotify-missing.c ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/gio/gunixfdmessage.h ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/gio/inotify/inotify-diag.h ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/gio/gunixconnection.h ostree-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ostree-embeddeps-2012.9/embedded-dependencies/glib/gio/inotify/inotify-diag.c ostree.x86_64: E: no-changelogname-tag ostree.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/ostree/libgthread-2.0.so.0 ['/builddir/build/BUILD/ostree-embeddeps-2012.9/embedded-dependencies/EMBEDDEPS/lib'] ostree.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/ostree/libgobject-2.0.so.0 ['/builddir/build/BUILD/ostree-embeddeps-2012.9/embedded-dependencies/EMBEDDEPS/lib'] ostree.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/ostree/libgobject-2.0.so.0.3311.0 ['/builddir/build/BUILD/ostree-embeddeps-2012.9/embedded-dependencies/EMBEDDEPS/lib'] ostree.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/ostree/libgmodule-2.0.so.0 ['/builddir/build/BUILD/ostree-embeddeps-2012.9/embedded-dependencies/EMBEDDEPS/lib'] ostree.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/ostree/libgthread-2.0.so.0.3311.0 ['/builddir/build/BUILD/ostree-embeddeps-2012.9/embedded-dependencies/EMBEDDEPS/lib'] ostree.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/ostree/libsoup-2.4.so.1 ['/builddir/build/BUILD/ostree-embeddeps-2012.9/embedded-dependencies/EMBEDDEPS/lib'] ostree.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/ostree/libgio-2.0.so.0 ['/builddir/build/BUILD/ostree-embeddeps-2012.9/embedded-dependencies/EMBEDDEPS/lib'] ostree.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/ostree/libgio-2.0.so.0.3311.0 ['/builddir/build/BUILD/ostree-embeddeps-2012.9/embedded-dependencies/EMBEDDEPS/lib'] ostree.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/ostree/libsoup-2.4.so.1.5.0 ['/builddir/build/BUILD/ostree-embeddeps-2012.9/embedded-dependencies/EMBEDDEPS/lib'] ostree.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/ostree/libgmodule-2.0.so.0.3311.0 ['/builddir/build/BUILD/ostree-embeddeps-2012.9/embedded-dependencies/EMBEDDEPS/lib'] ostree.x86_64: W: no-manual-page-for-binary ostree-switch-root ostree.x86_64: W: no-manual-page-for-binary ostadmin ostree.x86_64: W: no-manual-page-for-binary ostree-pull ostree.x86_64: W: no-manual-page-for-binary ostree-run-triggers ostree.src: E: no-changelogname-tag 3 packages and 0 specfiles checked; 101 errors, 5 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint ostree ostree.x86_64: E: no-changelogname-tag ostree.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/ostree/libgthread-2.0.so.0 ['/builddir/build/BUILD/ostree-embeddeps-2012.9/embedded-dependencies/EMBEDDEPS/lib'] ostree.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/ostree/libgobject-2.0.so.0 ['/builddir/build/BUILD/ostree-embeddeps-2012.9/embedded-dependencies/EMBEDDEPS/lib'] ostree.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/ostree/libgobject-2.0.so.0.3311.0 ['/builddir/build/BUILD/ostree-embeddeps-2012.9/embedded-dependencies/EMBEDDEPS/lib'] ostree.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/ostree/libgmodule-2.0.so.0 ['/builddir/build/BUILD/ostree-embeddeps-2012.9/embedded-dependencies/EMBEDDEPS/lib'] ostree.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/ostree/libgthread-2.0.so.0.3311.0 ['/builddir/build/BUILD/ostree-embeddeps-2012.9/embedded-dependencies/EMBEDDEPS/lib'] ostree.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/ostree/libsoup-2.4.so.1 ['/builddir/build/BUILD/ostree-embeddeps-2012.9/embedded-dependencies/EMBEDDEPS/lib'] ostree.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/ostree/libgio-2.0.so.0 ['/builddir/build/BUILD/ostree-embeddeps-2012.9/embedded-dependencies/EMBEDDEPS/lib'] ostree.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/ostree/libgio-2.0.so.0.3311.0 ['/builddir/build/BUILD/ostree-embeddeps-2012.9/embedded-dependencies/EMBEDDEPS/lib'] ostree.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/ostree/libsoup-2.4.so.1.5.0 ['/builddir/build/BUILD/ostree-embeddeps-2012.9/embedded-dependencies/EMBEDDEPS/lib'] ostree.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/ostree/libgmodule-2.0.so.0.3311.0 ['/builddir/build/BUILD/ostree-embeddeps-2012.9/embedded-dependencies/EMBEDDEPS/lib'] ostree.x86_64: W: no-manual-page-for-binary ostree-switch-root ostree.x86_64: W: no-manual-page-for-binary ostadmin ostree.x86_64: W: no-manual-page-for-binary ostree-pull ostree.x86_64: W: no-manual-page-for-binary ostree-run-triggers 1 packages and 0 specfiles checked; 11 errors, 4 warnings. # echo 'rpmlint-done:' Requires -------- ostree-debuginfo-2012.9-1.fc17.x86_64.rpm (rpmlib, GLIBC filtered): ostree-2012.9-1.fc17.x86_64.rpm (rpmlib, GLIBC filtered): /bin/bash /bin/sh libc.so.6()(64bit) libdl.so.2()(64bit) libffi.so.5()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgthread-2.0.so.0()(64bit) libostree.so()(64bit) libpthread.so.0()(64bit) libresolv.so.2()(64bit) librt.so.1()(64bit) libselinux.so.1()(64bit) libsoup-2.4.so.1()(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) libz.so.1()(64bit) libz.so.1(ZLIB_1.2.2)(64bit) rtld(GNU_HASH) Provides -------- ostree-debuginfo-2012.9-1.fc17.x86_64.rpm: ostree-debuginfo = 2012.9-1.fc17 ostree-debuginfo(x86-64) = 2012.9-1.fc17 ostree-2012.9-1.fc17.x86_64.rpm: libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgthread-2.0.so.0()(64bit) libostree.so()(64bit) libsoup-2.4.so.1()(64bit) ostree = 2012.9-1.fc17 ostree(x86-64) = 2012.9-1.fc17 MD5-sum check ------------- http://ftp.gnome.org/pub/GNOME/sources/ostree/2012.9/ostree-embeddeps-2012.9.tar.gz : CHECKSUM(SHA256) this package : e88fe67d32cf8622da434003d1dce435f32c449608967c0d253e2c5e903c1f73 CHECKSUM(SHA256) upstream package : e88fe67d32cf8622da434003d1dce435f32c449608967c0d253e2c5e903c1f73 Generated by fedora-review 0.2.0 (2fb2447) last change: 2012-07-22 Command line :./fedora-review -c -m fedora-17-x86_64 -b 819951 External plugins: -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review