https://bugzilla.redhat.com/show_bug.cgi?id=853692 --- Comment #6 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- 1. MUST remove BuildRequires: gcc-c++ it's included in http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 naming: ok licensing: ok 2. sources: not ok Source0: http://vicodan.fedorapeople.org/mate-settings-daemon-1.4.0.tar.gz MUST use verifiable upstream sources or provide justification why you're not doing so. scriptlets: ok (mostly, except for...) 3. MUST remove ldconfig from %pre,%post,%postun, this package has no shared libraries (just plugins), so it's not needed. 4. MUST own dir %{_libdir}/mate-settings-daemon-1.4.0/ I'd recommend just listing ^^ , instead of all items under that separately. scriptlets -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review