https://bugzilla.redhat.com/show_bug.cgi?id=824703 --- Comment #5 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> --- $ rpmlint -i -v * gnome-shell-theme-selene.src: I: checking gnome-shell-theme-selene.src: I: checking-url https://launchpad.net/~tista/+archive/selene (timeout 10 seconds) gnome-shell-theme-selene.src: W: no-%build-section The spec file does not contain a %build section. Even if some packages don't directly need it, section markers may be overridden in rpm's configuration to provide additional "under the hood" functionality, such as injection of automatic -debuginfo subpackages. Add the section, even if empty. gnome-shell-theme-selene.src:9: W: mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 6) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. gnome-shell-theme-selene.src: I: checking-url https://launchpad.net/~tista/+archive/selene/+files/gnome-shell-theme-selene_3.4.1-0ubuntu1~tista1.tar.gz (timeout 10 seconds) gnome-shell-theme-selene.noarch: I: checking gnome-shell-theme-selene.noarch: I: checking-url https://launchpad.net/~tista/+archive/selene (timeout 10 seconds) gnome-shell-theme-selene.spec: W: no-%build-section The spec file does not contain a %build section. Even if some packages don't directly need it, section markers may be overridden in rpm's configuration to provide additional "under the hood" functionality, such as injection of automatic -debuginfo subpackages. Add the section, even if empty. gnome-shell-theme-selene.spec:9: W: mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 6) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. gnome-shell-theme-selene.spec: I: checking-url https://launchpad.net/~tista/+archive/selene/+files/gnome-shell-theme-selene_3.4.1-0ubuntu1~tista1.tar.gz (timeout 10 seconds) 2 packages and 1 specfiles checked; 0 errors, 4 warnings. Please add a %build section. Well, it isn't needed for packages for which we just have to copy files. But perhaps you need in the future, and one more line doesn't eat really much disk space. Moreover, rpmlint is happy again. The mixed use of whitespaces and tabs has to be fixed, too. I recommend spaces, because that way the file view is the same in all text editors, independent from the configured tab width. BTW, there's a packager (don't remember his name for now) who insists on a tab width of five characters. Very annoying for a reviewer... -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review