[Bug 807383] Review Request: PythonMagick - Interface to ImageMagick for Python written in C++

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=807383

Jos de Kloe <josdekloe@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josdekloe@xxxxxxxxx

--- Comment #3 from Jos de Kloe <josdekloe@xxxxxxxxx> ---
rpmlint on the srpm reports these errors/warnings on some
textual issues, please fix them:

PythonMagick.src: W: name-repeated-in-summary C PythonMagick
PythonMagick.src: E: description-line-too-long C PythonMagick is an
object-oriented interface to ImageMagick which makes it possible
PythonMagick.src: E: description-line-too-long C to access the powerful image
manipulation features of ImageMagick from Python applications.
PythonMagick.src: E: description-line-too-long C Install this library if you
want to create, edit, compose, transform or convert images

rpmlint on the generated rpm file gives these additionals warnings:

PythonMagick.x86_64: W: private-shared-object-provides
/usr/lib64/python2.7/site-packages/PythonMagick/_PythonMagick.so
_PythonMagick.so()(64bit)
PythonMagick.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/python2.7/site-packages/PythonMagick/_PythonMagick.a

Avoiding a private shared object to be "provided" by an rpm can be done by
adding a filter like this:

%{?filter_setup:
%filter_provides_in %{python_sitearch}.*\.so$
%filter_setup
}

see: https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering

a library file is not needed to run the python module.
Therefore _PythonMagick.a should be packed into a separate devel package

see: https://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages
"""
When in doubt as to whether a file belongs in the base package or in -devel,
packagers should consider whether the file is necessary to be present for a
user to use or execute the functionality in the base package properly, or if it
is only necessary for development. If it is only necessary for development, it
must go into a -devel package. 
"""

Packages must NOT contain any .la libtool archives, these must be removed
in the spec if they are built.

Therefore please remove: _PythonMagick.la 

see: https://fedoraproject.org/wiki/Packaging/ReviewGuidelines
list of "MUST" items.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]