Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: hunspell-es - Spanish hunspell dictionaries https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228473 wolfy@xxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |wolfy@xxxxxxxxxxxxxxxxxx OtherBugsDependingO|163776 |163779 nThis| | Flag| |fedora-review+ ------- Additional Comments From wolfy@xxxxxxxxxxxxxxxxxx 2007-02-13 08:59 EST ------- GOOD - package meets naming guidelines - package meets packaging guidelines - spec file legible, in am. english - source matches upstream , sha1sum 3801efb6d6252e40a743a913afc4f86bb8d3a3ef es_ES.zip 4cc6bd6f5985d876f6d1bb565051b8131ddb82e4 es_MX.zip - the package builds in mock for devel/x86_64, generates a noarch (which is consistent with the fact that basically it includes only text files) - the license LGPL stated in the tag is the same as the one included in the source and is included in the package - there are only 2 files (word lists) + a short doc with instructions and license clearance, so no need for -doc and no .la, .pc, static files - no missing BR - no locales - not relocatable - owns all files/directories that it creates, does not take ownership of other files/dirs - no duplicate files - permissions ok - %clean ok - macro use consistent - rpmlint output is silent - code, not content - no need for -docs as the only doc are just the LGPL licenses (localised for Spain and Mexico) - nothing in %doc affects runtime - no need for .desktop file APPROVED PS: You could also add support for es_BZ (Belize), es_CU (Cuba), es_GU (Guatemala) Please bug upstream to update the corresponding Readme files on http://ftp.services.openoffice.org/pub/OpenOffice.org/contrib/dictionaries/, over there the license is stated to be GPL and not LGPL as the ones included in the zip files. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review