https://bugzilla.redhat.com/show_bug.cgi?id=853694 --- Comment #1 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- naming: ok sources: ok 9eebb9972d1759dd001ba78fe66bde09 mate-control-center-1.4.0.tar.xz scriptlets: ok 1. licensing: there is a mixture of LGPLv2+ and GPLv2+ sources, SHOULD simplify to just: License: GPLv2+ 2. MUST omit all stuff under %{_datadir}/mime, except for anything matching %{_datadir}/mime/packages/*.xml that's generated content from scriptlets (and the current stuff you list would conflict with shared-mime-info), see also item 3 3. MUST add mimeinfo-related scriptlets: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#mimeinfo 4. MUST add .desktop mime-related scriptlets: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-database 5. MUST drop not-needed BuildRequires: gtk+-devel -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review