https://bugzilla.redhat.com/show_bug.cgi?id=847517 --- Comment #5 from Shawn Iwinski <shawn.iwinski@xxxxxxxxx> --- (In reply to comment #4) > (In reply to comment #3) > > In %check, I'm assuming "ping -c 1 dns.google.com" is to check whether the > > build host is connected to a public network and will then run all tests? > > Yes. > But it also check that resolver works. > So, as still prefer a name rather that an ip (and a server allowing ping) But your ping test would check that the build machine's DNS is set up and resolving correctly. As far as I understand the package, it could work regardless of whether the build machine's DNS is set up correctly or not by correctly providing DNS nameserver IP addresses (and the package resolver test uses the Google Public DNS IPs). If you really prefer a DNS name, perhaps use "google.com" instead? I believe this would resolve for more people than "dns.google.com" -- this would match the actual package resolver test as well. > > dns.google.com does not resolve on my machine and may not for other building > > machines. Perhaps instead use one of the Google Public DNS IP addresses > > used in the resolver test file since they respond to pings as well? -- > > 8.8.8.8 or 8.8.4.4 > > In our case, koji won't run this test. This is the designed behavior. > > Do you think this is a blocker for the review ? No, not a blocker ;) -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review