Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ogdi - Open Geographic Datastore Interface https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222039 ------- Additional Comments From pertusus@xxxxxxx 2007-02-13 07:35 EST ------- * in %files, there is no need of * for odbc, so %{_libdir}/%{name}/liblodbc.so* should be replaced with %{_libdir}/%{name}/liblodbc.so * no need to duplicate the documentation in all the subpackages. LICENSE NEWS ChangeLog README could be only in the main package. * HOWTO-RELEASE isn't usefull in the fedora package * The following is useless and should be removed: %post tcl -p /sbin/ldconfig %postun tcl -p /sbin/ldconfig * there is a license issue for vpflib. In LICENSE, there is: vpflib/*: No license mentioned, public domain? However some files in vpflib have an author, which means a copyright owner. Without license they are under the default license which is a restrictive license (no redistribution, no modification). * there is also a license issue for ogdi/c-api/gmath.c: ogdi/c-api/gmath.c is: Derived from Numerical methods in C Looking at this book it seems that the codes are under a proprietary license. Suggestions: * The timestamps of source file aren't the same that those spectool -g gets (but otherwise source match upstream) * use %defattr(-,root,root,-) instead of %defattr(-,root,root) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review