https://bugzilla.redhat.com/show_bug.cgi?id=847811 Michael Schwendt <mschwendt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mschwendt@xxxxxxxxx Depends On| |847817 --- Comment #4 from Michael Schwendt <mschwendt@xxxxxxxxx> --- > Summary: An event expression library inspired by CEE Not covered by any guidelines, but in many cases the leading article is superfluous and doesn't increase conciseness. Summary: Event expression library inspired by CEE That makes a much better reading when displayed by Anaconda and package tools. > License: LGPLv2+ True. The majority of source files contain an LGPLv2+ preamble. Only src/cjson/* contains merged files with an MIT-style preamble. There's a minor typo at the top of file COPYING, which refers to GPL rather than LGPL. > Group: Development/Libraries Base library packages still enter group "System Environment/Libraries". > %description I would rearrange the two paragraphs to begin with the explanation of what libee does, then continue with the explanation of what CEE is. > %package devel > Summary: Include files for libee More generally, it's Summary: Development files for libee because not just the header files are included. > Requires: %name = %version-%release https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package > %package utils > Summary: The libee-convert utility provided by event expression library > Requires: %{name} = %{version}-%{release} Same here. The summary restricts the package contents to just the libee-convert utility. It could be made more general to sum up whether these tools are optional or strictly needed. > %{__make} https://fedoraproject.org/wiki/Packaging:Guidelines#Parallel_make Plus: if you don't have a compelling reason to use a macro here, feel free to run "make" from $PATH just as done with many other commands one runs in .spec files. > %install > rm -rf %{buildroot} It will be automatically cleaned: https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review