https://bugzilla.redhat.com/show_bug.cgi?id=855665 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- Source tar ball is original (verified from <http://search.cpan.org/CPAN/authors/id/A/AU/AUBERTG/Data-Validate-Type-1.3.0.tar.gz>, SHA-256: 07427ea61b26a55a1afde85c5b3215ce714702903bd6ac0fe58d45f9904d215f). Ok. Source0 and URL are usable. Ok. Summary verified from lib/Data/Validate/Type.pm. Description is Ok. License verified from LICENSE, lib/Data/Validate/Type.pm, and t/LocalTest.pm. Ok. No XS code, noarch BuildArch is Ok. TODO: You can remove pruning empty directories from %install section. TODO: Do not package ignore.txt as documentation. TODO: Do not package META.json as documentation. TODO: Build-require `perl(Exporter)' (lib/Data/Validate/Type.pm:6). TODO: Build-require `perl(base)' (lib/Data/Validate/Type.pm:6). TODO: Build-require `perl(lib)' (t/20-hashref.t:8). All tests pass. Ok. $ rpmlint perl-Data-Validate-Type.spec ../SRPMS/perl-Data-Validate-Type-1.3.0-1.fc19.src.rpm ../RPMS/noarch/perl-Data-Validate-Type-1.3.0-1.fc19.noarch.rpm perl-Data-Validate-Type.src: W: spelling-error Summary(en_US) Util -> Til, U til, Until perl-Data-Validate-Type.src: W: spelling-error %description -l en_US Util -> Til, U til, Until perl-Data-Validate-Type.noarch: W: spelling-error Summary(en_US) Util -> Til, U til, Until perl-Data-Validate-Type.noarch: W: spelling-error %description -l en_US Util -> Til, U til, Until 2 packages and 1 specfiles checked; 0 errors, 4 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Data-Validate-Type-1.3.0-1.fc19.noarch.rpm drwxr-xr-x 2 root root 0 Sep 14 10:55 /usr/share/doc/perl-Data-Validate-Type-1.3.0 -rw-r--r-- 1 root root 806 Sep 9 04:59 /usr/share/doc/perl-Data-Validate-Type-1.3.0/Changes -rw-r--r-- 1 root root 1662 Sep 9 04:59 /usr/share/doc/perl-Data-Validate-Type-1.3.0/META.json -rw-r--r-- 1 root root 1439 Sep 9 04:59 /usr/share/doc/perl-Data-Validate-Type-1.3.0/README -rw-r--r-- 1 root root 128 Sep 9 04:59 /usr/share/doc/perl-Data-Validate-Type-1.3.0/ignore.txt -rw-r--r-- 1 root root 4698 Sep 14 10:55 /usr/share/man/man3/Data::Validate::Type.3pm.gz drwxr-xr-x 2 root root 0 Sep 14 10:55 /usr/share/perl5/vendor_perl/Data drwxr-xr-x 2 root root 0 Sep 14 10:55 /usr/share/perl5/vendor_perl/Data/Validate -rw-r--r-- 1 root root 19674 Sep 14 10:55 /usr/share/perl5/vendor_perl/Data/Validate/Type.pm File permissions and layout are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Data-Validate-Type-1.3.0-1.fc19.noarch.rpm | sort | uniq -c 1 perl(base) 1 perl(Carp) 1 perl(Data::Dump) 1 perl(Exporter) 1 perl(:MODULE_COMPAT_5.16.1) 1 perl(Params::Util) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Data-Validate-Type-1.3.0-1.fc19.noarch.rpm | sort | uniq -c 1 perl(Data::Validate::Type) = 1.3.0 1 perl-Data-Validate-Type = 1.3.0-1.fc19 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Data-Validate-Type-1.3.0-1.fc19.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F19 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4483009). Ok. Package is in line with Fedora and Perl packaging guidelines. Please consider fixing `TODO' items before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review