https://bugzilla.redhat.com/show_bug.cgi?id=855656 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- Source tar ball is original (verified from <http://search.cpan.org/CPAN/authors/id/M/MS/MSTROUT/Safe-Isa-1.000002.tar.gz>, SHA-256: 74f3fbbc296183a7cacada11304073a67a4beca4fd77aa2eff89af6fbc23591e). Ok. Source0 and URL are usable. Ok. Summary verified from lib/Safe/Isa.pm. Ok. Description verified from lib/Safe/Isa.pm. Ok. License verified from lib/Safe/Isa.pm. Ok. No XS code, noarch BuildArch is Ok. Build-time dependencies are Ok. All tests pass. Ok. $ rpmlint perl-Safe-Isa.spec ../SRPMS/perl-Safe-Isa-1.000002-1.fc19.src.rpm ../RPMS/noarch/perl-Safe-Isa-1.000002-1.fc19.noarch.rpm perl-Safe-Isa.src: W: spelling-error %description -l en_US Util -> Til, U til, Until perl-Safe-Isa.noarch: W: spelling-error %description -l en_US Util -> Til, U til, Until 2 packages and 1 specfiles checked; 0 errors, 2 warnings. rpmlint us Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Safe-Isa-1.000002-1.fc19.noarch.rpm drwxr-xr-x 2 root root 0 Sep 13 17:29 /usr/share/doc/perl-Safe-Isa-1.000002 -rw-r--r-- 1 root root 232 Jul 19 21:00 /usr/share/doc/perl-Safe-Isa-1.000002/Changes -rw-r--r-- 1 root root 3713 Jul 19 21:00 /usr/share/doc/perl-Safe-Isa-1.000002/README -rw-r--r-- 1 root root 3232 Sep 13 17:29 /usr/share/man/man3/Safe::Isa.3pm.gz drwxr-xr-x 2 root root 0 Sep 13 17:29 /usr/share/perl5/vendor_perl/Safe -rw-r--r-- 1 root root 4003 Jul 19 21:00 /usr/share/perl5/vendor_perl/Safe/Isa.pm File permissions and layout are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Safe-Isa-1.000002-1.fc19.noarch.rpm | sort | uniq -c 1 perl(base) 1 perl(Exporter) 1 perl(:MODULE_COMPAT_5.16.1) 1 perl(Scalar::Util) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Safe-Isa-1.000002-1.fc19.noarch.rpm | sort | uniq -c 1 perl(Safe::Isa) = 1.000002 1 perl-Safe-Isa = 1.000002-1.fc19 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Safe-Isa-1.000002-1.fc19.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F19 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4481430). Ok. Package is in line with Fedora and Perl packaging guidelines. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review