https://bugzilla.redhat.com/show_bug.cgi?id=835804 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #3 from Petr Pisar <ppisar@xxxxxxxxxx> --- Spec file changes: --- perl-Module-Install-ReadmeMarkdownFromPod.spec.old 2012-06-27 09:18:38.000000000 +0200 +++ perl-Module-Install-ReadmeMarkdownFromPod.spec 2012-09-13 16:52:23.000000000 +0200 @@ -9,12 +9,20 @@ BuildArch: noarch BuildRequires: perl >= 1:5.6.0 # XXX: We cannot remove ./inc because it build-requires this module -BuildRequires: perl(ExtUtils::MakeMaker) BuildRequires: perl(base) -BuildRequires: perl(Module::Install::Base) -BuildRequires: perl(Module::Install::ReadmeFromPod) -BuildRequires: perl(Pod::Markdown) -BuildRequires: perl(Test::More) >= 0.70 +BuildRequires: perl(Carp) +BuildRequires: perl(CPAN) >= 1.89 +BuildRequires: perl(Cwd) +BuildRequires: perl(ExtUtils::Command) +BuildRequires: perl(ExtUtils::MakeMaker) +BuildRequires: perl(ExtUtils::Manifest) +BuildRequires: perl(File::Path) +BuildRequires: perl(File::Spec) +BuildRequires: perl(Pod::Parser) +BuildRequires: perl(Pod::Text) +BuildRequires: perl(Test::Builder::Module) +BuildRequires: perl(Test::Harness) +BuildRequires: perl(URI::Escape) Requires: perl(Module::Install) Requires: perl(Module::Install::ReadmeFromPod) Requires: perl(Pod::Markdown) @@ -29,16 +37,17 @@ %prep %setup -q -n Module-Install-ReadmeMarkdownFromPod-%{version} +# README is ISO-8859-1 encoded +iconv -f iso-8859-1 -t utf8 < README > README.utf8 +mv README.utf8 README + %build %{__perl} Makefile.PL INSTALLDIRS=vendor make %{?_smp_mflags} %install make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT - find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} \; -find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \; - %{_fixperms} $RPM_BUILD_ROOT/* %check > TODO: You can remove pruning empty directories from %install section. %install make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT - find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} \; -find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \; - %{_fixperms} $RPM_BUILD_ROOT/* Ok. > TODO: Do not build-require modules bundled in ./inc or remove them from the > directory. > FIX: Specify ./inc dependencies or unbundle the modules (e.g. `perl(Cwd)' at inc/Module/Install.pm:123:use). -BuildRequires: perl(ExtUtils::MakeMaker) BuildRequires: perl(base) -BuildRequires: perl(Module::Install::Base) -BuildRequires: perl(Module::Install::ReadmeFromPod) -BuildRequires: perl(Pod::Markdown) -BuildRequires: perl(Test::More) >= 0.70 +BuildRequires: perl(Carp) +BuildRequires: perl(CPAN) >= 1.89 +BuildRequires: perl(Cwd) +BuildRequires: perl(ExtUtils::Command) +BuildRequires: perl(ExtUtils::MakeMaker) +BuildRequires: perl(ExtUtils::Manifest) +BuildRequires: perl(File::Path) +BuildRequires: perl(File::Spec) +BuildRequires: perl(Pod::Parser) +BuildRequires: perl(Pod::Text) +BuildRequires: perl(Test::Builder::Module) +BuildRequires: perl(Test::Harness) +BuildRequires: perl(URI::Escape) Ok. > FIX: Recode README to UTF-8. $ rpmlint perl-Module-Install-ReadmeMarkdownFromPod.spec ../SRPMS/perl-Module-Install-ReadmeMarkdownFromPod-0.03-1.fc19.src.rpm ../RPMS/noarch/perl-Module-Install-ReadmeMarkdownFromPod-0.03-1.fc19.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. Ok. Package builds in F19 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4481355). Ok. Package is in line with Fedora and Perl packaging guidelines. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review