https://bugzilla.redhat.com/show_bug.cgi?id=851734 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #5 from Petr Pisar <ppisar@xxxxxxxxxx> --- Spec file changes: --- perl-Regexp-Grammars.spec.old 2012-09-12 17:19:48.779482617 +0200 +++ perl-Regexp-Grammars.spec 2012-09-12 18:37:38.000000000 +0200 @@ -1,22 +1,29 @@ Name: perl-Regexp-Grammars Version: 1.021 -Release: 2%{?dist} +Release: 3%{?dist} Summary: Add grammatical parsing features to perl regular expressions License: GPL+ or Artistic Group: Development/Libraries URL: http://search.cpan.org/dist/Regexp-Grammars/ Source0: http://www.cpan.org/authors/id/D/DC/DCONWAY/Regexp-Grammars-%{version}.tar.gz BuildArch: noarch -BuildRequires: perl(ExtUtils::MakeMaker) BuildRequires: perl(Module::Build) BuildRequires: perl(Test::More) BuildRequires: perl(Test::Pod) +BuildRequires: perl(Scalar::Util) +BuildRequires: perl(Data::Dumper) +BuildRequires: perl(List::Util) +BuildRequires: perl(Moose) +BuildRequires: perl(Moose::Util::TypeConstraints) +Requires: perl(Data::Dumper) Requires: perl(Scalar::Util) Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) -%filter_from_requires /perl(List::Util)/ +%filter_from_provides /perl(Regexp)/d +%filter_provides_in %{_docdir} %filter_setup + %description This module adds a small number of new regular expressions constructs that can be used to implement complete recursive-descent parsing. @@ -44,6 +51,12 @@ %{_mandir}/man3/Regexp::Grammars.3pm* %changelog +* Wed Sep 12 2012 Bill Pemberton <wfp5p@xxxxxxxxxxxx> - 1.021-3 +- update Requires and BuildRequires +- remove filter_from_requires +- filter out requirements of the demo scripts +- filter out perl(Regexp) from provides + * Mon Aug 27 2012 Bill Pemberton <wfp5p@xxxxxxxxxxxx> - 1.021-2 - Remove BuildRoot > TODO: Remove useless `perl(ExtUtils::MakeMaker)' build-require. Your spec file > utilizes Module::Build build system. -BuildRequires: perl(ExtUtils::MakeMaker) Ok. > FIX: Build-require `perl(Scalar::Util)' for running tests > (lib/Regexp/Grammars.pm:10). +BuildRequires: perl(Scalar::Util) Ok. > FIX: Build-require `perl(Data::Dumper)' for running tests > (lib/Regexp/Grammars.pm:11). +BuildRequires: perl(Data::Dumper) Ok. > TODO: Build-require `perl(Moose)' for optional tests (t/moose.t:5). > TODO: Build-require `perl(Moose::Util::TypeConstraints)' for optional tests > (t/moose.t:13). +BuildRequires: perl(Moose) +BuildRequires: perl(Moose::Util::TypeConstraints) Ok. > FIX: Build-require `perl(List::Util)' for running tests (t/error_translate.t:5). +BuildRequires: perl(List::Util) Ok. > FIX: %filter_from_requires /perl(List::Util)/ is not valid sed expression: -%filter_from_requires /perl(List::Util)/ Ok. All tests pass. Ok. $ rpmlint perl-Regexp-Grammars.spec ../SRPMS/perl-Regexp-Grammars-1.021-3.fc19.src.rpm ../RPMS/noarch/perl-Regexp-Grammars-1.021-3.fc19.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Regexp-Grammars-1.021-3.fc19.noarch.rpm | sort | uniq -c 1 perl >= 1:5.010 1 perl >= 1:5.10 2 perl(Data::Dumper) 1 perl(List::Util) 1 perl(:MODULE_COMPAT_5.16.1) 1 perl(mro) 1 perl(overload) 1 perl(Regexp::Grammars) 2 perl(Scalar::Util) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 > FIX: Run-require `perl(Data::Dumper)' (lib/Regexp/Grammars.pm:11). Ok. TODO: Do not explicitly run-require `perl(Data::Dumper)' and `perl(Scalar::Util)'. They are automatically discovered after the filter expression being made valid. > FIX: Do not provide `perl(Calculator_Actions)' from demo in documentation. > Fix: Do not provide private `perl(Regexp)' (this would clash with `Regexp' > CPAN module). $ rpm -q --provides -p ../RPMS/noarch/perl-Regexp-Grammars-1.021-3.fc19.noarch.rpm | sort | uniq -c 1 perl(Regexp::Grammars) = 1.021 1 perl-Regexp-Grammars = 1.021-3.fc19 1 perl(Regexp::Grammars::Precursor) Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Regexp-Grammars-1.021-3.fc19.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F19 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4480141). Ok. Package is in line with Fedora and Perl packaging guidelines. Please consider fixing the `TODO' items before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review