[Bug 853553] Review Request: guayadeque - Audio player and organizer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=853553

--- Comment #8 from Brendan Jones <brendan.jones.it@xxxxxxxxx> ---
Hi Martin,

just a few comments:
 - use %{name} in your files section
 - remove all your unnecessary Requires. RPM will determine all of these
correctly, so no need to explicitly include them [1]

I also get a build error when building in mock (F17). I will submit a scratch
build for f18 and post the results

-- Found Subversion: /usr/bin/svn (found version "1.6.18") 
CMake Error at /usr/share/cmake/Modules/FindSubversion.cmake:83 (MESSAGE):
  Command "/usr/bin/svn info /builddir/build/BUILD/guayadeque-svn1830" failed
  with output:
  svn: The path '/builddir/build/BUILD/guayadeque-svn1830' appears to be part
  of a Subversion 1.7 or greater
  working copy.  Please upgrade your Subversion client to use this
  working copy.
Call Stack (most recent call first):
  CMakeLists.txt:122 (Subversion_WC_INFO)
Current revision is 
-- Found Gettext: /usr/bin/msgmerge (found version "0.18.1") 
-- Configuring incomplete, errors occurred!
error: Bad exit status from /var/tmp/rpm-tmp.mvv1Fs (%build)
    Bad exit status from /var/tmp/rpm-tmp.mvv1Fs (%build)
RPM build errors:
Child return code was: 1


[1] http://fedoraproject.org/wiki/Packaging:Guidelines#Requires

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]