https://bugzilla.redhat.com/show_bug.cgi?id=835062 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- Source tar ball is original (verified from <http://search.cpan.org/CPAN/authors/id/B/BI/BINGOS/Module-Install-ReadmeFromPod-0.18.tar.gz>, SHA-256: a905bf3699af2c6727991634d5ae004d64b8e9279ad01eb696d8b8bbe571bdfb). Ok. Source0 and URL are usable. Ok. Summary verified from lib/Module/Install/ReadmeFromPod.pm. Ok. Description verified from lib/Module/Install/ReadmeFromPod.pm. Ok. License verified from lib/Module/Install/ReadmeFromPod.pm and LICENSE. Ok. No XS code, noarch BuildArch is Ok. TODO: Build-require `perl(lib)' (Makefile.PL:2). TODO: Remove useless build-require `perl(ExtUtils::MakeMaker)'. TODO: I recommend to drop `perl(App:pod2pdf)' from dependencies. The package is properly evaluated and it pulls in a lot packages which are not needed otherwise. TODO: Remove cleaning empty directories from %install section. This is default now. All tests pass. Ok. $ rpmlint perl-Module-Install-ReadmeFromPod.spec ../SRPMS/perl-Module-Install-ReadmeFromPod-0.18-1.fc19.src.rpm ../RPMS/noarch/perl-Module-Install-ReadmeFromPod-0.18-1.fc19.noarch.rpm perl-Module-Install-ReadmeFromPod.src: W: spelling-error %description -l en_US manpage -> manage, man page, man-page perl-Module-Install-ReadmeFromPod.noarch: W: spelling-error %description -l en_US manpage -> manage, man page, man-page 2 packages and 1 specfiles checked; 0 errors, 2 warnings. TODO: Write the `manpage' as `manual page' in the description. $ rpm -q -lv -p ../RPMS/noarch/perl-Module-Install-ReadmeFromPod-0.18-1.fc19.noarch.rpm drwxr-xr-x 2 root root 0 Sep 12 13:53 /usr/share/doc/perl-Module-Install-ReadmeFromPod-0.18 -rw-r--r-- 1 root root 6814 Feb 25 2012 /usr/share/doc/perl-Module-Install-ReadmeFromPod-0.18/Changes -rw-r--r-- 1 root root 18353 Sep 12 13:52 /usr/share/doc/perl-Module-Install-ReadmeFromPod-0.18/LICENSE drwxr-xr-x 2 root root 0 Feb 25 2012 /usr/share/doc/perl-Module-Install-ReadmeFromPod-0.18/tools -rw-r--r-- 1 root root 2299 Feb 6 2012 /usr/share/doc/perl-Module-Install-ReadmeFromPod-0.18/tools/git-log.pl -rw-r--r-- 1 root root 3109 Sep 12 13:52 /usr/share/man/man3/Module::Install::ReadmeFromPod.3pm.gz drwxr-xr-x 2 root root 0 Sep 12 13:52 /usr/share/perl5/vendor_perl/Module drwxr-xr-x 2 root root 0 Sep 12 13:52 /usr/share/perl5/vendor_perl/Module/Install -rw-r--r-- 1 root root 6356 Feb 25 2012 /usr/share/perl5/vendor_perl/Module/Install/ReadmeFromPod.pm File permissions and layout is Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Module-Install-ReadmeFromPod-0.18-1.fc19.noarch.rpm | sort | uniq -c 1 perl >= 0:5.006 1 perl(App::pod2pdf) 1 perl(base) 1 perl(:MODULE_COMPAT_5.16.1) 1 perl(Module::Install) >= 1 1 perl(Module::Install::Base) 1 perl(Pod::Html) 1 perl(Pod::Man) 1 perl(Pod::Text) >= 3.13 1 perl(strict) 1 perl(vars) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Module-Install-ReadmeFromPod-0.18-1.fc19.noarch.rpm | sort | uniq -c 1 perl(Module::Install::ReadmeFromPod) = 0.18 1 perl-Module-Install-ReadmeFromPod = 0.18-1.fc19 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Module-Install-ReadmeFromPod-0.18-1.fc19.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F19 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4477405). Ok. Package is in line with Fedora and Perl packaging guidelines. Please consider fixing all `TODO' items before building the package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review