https://bugzilla.redhat.com/show_bug.cgi?id=856217 Matthias Runge <mrunge@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mrunge@xxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |mrunge@xxxxxxxxxx Flags| |fedora-review? --- Comment #2 from Matthias Runge <mrunge@xxxxxxxxxx> --- Some drive-by comments: - no need to define BuildRoot: anymore - you don't need to clean the buildroot during install anymore - even the clean: section is not required anymore - no need to defattr in %files section, only, when building for epel5 Those four are deprecated and shouldn't be used any more. - project homepage is currently: http://sourceforge.net/projects/quearcode/ (unless you'll configure projects sf-page else ;-) ) quearcode.src: W: invalid-url URL: http://quearcode.sourceforge.net HTTP Error 403: Forbidden Full review to follow. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review