https://bugzilla.redhat.com/show_bug.cgi?id=823102 --- Comment #4 from pcpa <paulo.cesar.pereira.de.andrade@xxxxxxxxx> --- (In reply to comment #2) Thanks for the review. > Spec URL in #1 is incorrect. But I guessed the correct one :) > http://fedorapeople.org/~pcpa/0ad-data.spec Ops, cut&paste fail :-) [...] > Issues: > See: > http://fedoraproject.org/wiki/Packaging/ > LicensingGuidelines#ValidLicenseShortNames > [!] rpmlint warning: > 0ad-data.src:10: W: mixed-use-of-spaces-and-tabs (spaces: line 10, tab: > line 3) Very simple, will correct. > [!]: MUST Spec file is legible and written in American English. > Please append at the end of %desciption some statement, that this is > just data for the game and the game itself reside in 0ad package. > Because current description is same as 0ad and we should distinguish > these two by description as well. Ok. Will add a note at the end of the %description. > [!]: SHOULD If the source package does not include license text(s) as a > separate file from upstream, the packager SHOULD query upstream to > include it. > This is not blocker, but please do that. Actually, there are already license files packed in public.zip. public/art/LICENSE.txt: """ The files in this directory are Copyright (C) 2009 Wildfire Games. These files are licensed under the Creative Commons Attribution-Share Alike 3.0 (CC-by-sa) license, available at http://creativecommons.org/licenses/by-sa/3.0/ Briefly, this means: * You may use, modify and distribute these files, for commercial and non-commercial purposes. * If you distribute one of these files, you must include attribution (e.g. in the credits screen of a game or a video, or in a text file accompanying the files). The attribution must include: * A link to http://creativecommons.org/licenses/by-sa/3.0/ * The name "Wildfire Games" as the original author * A link to http://www.wildfiregames.com/ * If you distribute one of these files, you must release it (and any modifications you have made to it) under the CC-by-sa license. Some of the files in the "textures/" directory are derived from materials provided by CGTextures (http://www.cgtextures.com/). The original materials are the property of CGTextures or its contributors. Special permission has been granted by CGTextures to distribute these derived textures as CC-BY-SA. (This has no effect on the standard licensing of CGTextures materials, or on any other work derived from them.) All CGTextures materials have been altered from their original form. To access original super-high resolution CGTextures materials, please visit http://www.cgtextures.com/ . """ public/audio/LICENSE.txt: """ The files in this directory are Copyright (C) 2009 Wildfire Games. These files are licensed under the Creative Commons Attribution-Share Alike 3.0 (CC-by-sa) license, available at http://creativecommons.org/licenses/by-sa/3.0/ Briefly, this means: * You may use, modify and distribute these files, for commercial and non-commercial purposes. * If you distribute one of these files, you must include attribution (e.g. in the credits screen of a game or a video, or in a text file accompanying the files). The attribution must include: * A link to http://creativecommons.org/licenses/by-sa/3.0/ * The name "Wildfire Games" as the original author * A link to http://www.wildfiregames.com/ * If you distribute one of these files, you must release it (and any modifications you have made to it) under the CC-by-sa license. """ Well, I believe I may have found a showstopper for 0ad in fedora... -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review