https://bugzilla.redhat.com/show_bug.cgi?id=851180 greg.hellings@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |greg.hellings@xxxxxxxxx --- Comment #1 from greg.hellings@xxxxxxxxx --- I'm no RPM creating professional but here's my feedback: The %clean section is apparently no longer necessary and should be removed from your spec file. The line "rm -rf ${RPM_BUILD_ROOT}" at the beginning of your install is no longer necessary and should be removed from your spec file. You install line should use the macro "$mingw_make_install DESTDIR=${RPM_BUILD_ROOT}" instead of using "%mingw_make install". I'm also not sure if the INSTALL="install -p" parameter is necessary. Is it? The lines under your %files sections which begin %defattr are no longer necessary and should be purged from your file. The BuildRoot: line at the top of your file should be removed. The RPM building process uses sane roots already and the default values should really be used. Below is the output of rpmlint on the results. It seems pretty clean to me. greg@Gateway08:~/Source/fedora-mingw-staging/mingw-lcms $ rpmlint mingw-lcms-1.19-1.fc19.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. greg@Gateway08:~/Source/fedora-mingw-staging/mingw-lcms $ rpmlint noarch/mingw mingw32-lcms-1.19-1.fc19.noarch.rpm mingw64-lcms-1.19-1.fc19.noarch.rpm mingw32-lcms-debuginfo-1.19-1.fc19.noarch.rpm mingw64-lcms-debuginfo-1.19-1.fc19.noarch.rpm mingw32-lcms-static-1.19-1.fc19.noarch.rpm mingw64-lcms-static-1.19-1.fc19.noarch.rpm greg@Gateway08:~/Source/fedora-mingw-staging/mingw-lcms $ rpmlint noarch/mingw32-lcms-1.19-1.fc19.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. greg@Gateway08:~/Source/fedora-mingw-staging/mingw-lcms $ rpmlint noarch/mingw32-lcms-debuginfo-1.19-1.fc19.noarch.rpm mingw32-lcms-debuginfo.noarch: E: debuginfo-without-sources 1 packages and 0 specfiles checked; 1 errors, 0 warnings. greg@Gateway08:~/Source/fedora-mingw-staging/mingw-lcms $ rpmlint noarch/mingw32-lcms-static-1.19-1.fc19.noarch.rpm mingw32-lcms-static.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. greg@Gateway08:~/Source/fedora-mingw-staging/mingw-lcms $ rpmlint noarch/mingw64-lcms-1.19-1.fc19.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. greg@Gateway08:~/Source/fedora-mingw-staging/mingw-lcms $ rpmlint noarch/mingw64-lcms-debuginfo-1.19-1.fc19.noarch.rpm mingw64-lcms-debuginfo.noarch: E: debuginfo-without-sources 1 packages and 0 specfiles checked; 1 errors, 0 warnings. greg@Gateway08:~/Source/fedora-mingw-staging/mingw-lcms $ rpmlint noarch/mingw64-lcms-static-1.19-1.fc19.noarch.rpm mingw64-lcms-static.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review