https://bugzilla.redhat.com/show_bug.cgi?id=772986 Adam Huffman <bloch@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #7 from Adam Huffman <bloch@xxxxxxxxxxxx> --- Good, I thought they were there for a reason and tend to check the .spec file in detail after any major problems have been caught by rpmlint et al. Looks good. The only other comment I would make is that I personally prefer consistency in macro usage i.e. %{buildroot} instead of $RPM_BUILD_ROOT, if most are using the newer style. Maybe worth considering for the next update. APPROVED -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review