Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: coreutils https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225655 ------- Additional Comments From mastahnke@xxxxxxxxx 2007-02-13 00:37 EST ------- rpmlint output is below Package named correctly Spec file matches package name GPL license confirmed, however actual text not included in package Spec is in English Spec file is readable md5sums from upstream match source in SRPM builds on i386 all build dependencies listed SHOULD: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available. -- since this a key package, this might be good Spec file does not use macros for bin, sbin and what not throughout. Use of prereq, which isn't seen much anymore. Usually, the PreReq tag should be replaced by plain Requires. [builder@rawhide i386]$ rpmlint coreutils-6.7-3.i386.rpm E: coreutils setuid-binary /bin/su root 04755 E: coreutils non-standard-executable-perm /bin/su 04755 E: coreutils executable-marked-as-config-file /etc/profile.d/colorls.sh E: coreutils executable-sourced-script /etc/profile.d/colorls.sh 0755 E: coreutils executable-marked-as-config-file /etc/profile.d/colorls.csh E: coreutils executable-sourced-script /etc/profile.d/colorls.csh 0755 W: coreutils dangerous-command-in-%pre rm W: coreutils dangerous-command-in-%post mv [builder@rawhide SRPMS]$ rpmlint coreutils-6.7-3.src.rpm W: coreutils strange-permission colorls.sh 0775 W: coreutils strange-permission colorls.csh 0775 W: coreutils prereq-use /sbin/install-info W: coreutils prereq-use grep, findutils W: coreutils unversioned-explicit-provides stat W: coreutils unversioned-explicit-obsoletes fileutils W: coreutils unversioned-explicit-obsoletes sh-utils W: coreutils unversioned-explicit-obsoletes stat W: coreutils unversioned-explicit-obsoletes textutils W: coreutils make-check-outside-check-section make check W: coreutils mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 13) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review