[Bug 854764] Review Request:openshift-origin-port-proxy - Script to configure HAProxy to do port forwarding for OpenShift Origin

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=854764

--- Comment #1 from Michael Scherer <misc@xxxxxxxx> ---
Hi, a few notes :
* why does it requires procmail ? 
if that's for flock ( used in the script ), this is utils-linux in f17

* since openshift is not planned to run on epel5, I think you should clean the
various stuff for epel5 ( %defattr, BuildRoot tag, rm -Rf in %clean, etc ) 

* why is the config copied in %post and not directly placed there directly by
the rpm, and why do you run restorecon for that ? ( and why not run it with the
configuration from /etc/ directly ? )

* spec would IMHO be cleaner with only non defaut %attr

* why are permission initscript set to 750, as there is

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]