Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gtkpod - Graphical song management program for Apple's iPod Alias: gtkpod-review https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228425 ------- Additional Comments From lxtnow@xxxxxxxxx 2007-02-12 23:40 EST ------- -------- BuildRequires -------- * gtk2-devel for BuildRequires is redundant. libglade2-devel requires gtk2-devel. -------- %prep -------- * You should comment why you apply a patch. * Desktop file: personnaly, i don't like to use cat << eof to create desktop file. I think it's better to add desktop file as Source file. "X-livna" must be removed from categorie. --------- %build --------- looks good --------- %install --------- * Please use install -Dm 644 instead of %{__install} -D -m 0644 * Same thing for %{__mkdir_p}. * in desktop-file-intall entry: use of "--vendor livna" is deprecated and must be removed, just use --vendor "" Also add --mode 0644 --------- Scriptlet --------- you should make use of GTK+ icon cache See : http://fedoraproject.org/wiki/Packaging/ScriptletSnippets?action=show&redirect=ScriptletSnippets#head-7103f6c38d1b5735e8477bdd569ad73ea2c49bda %post touch --no-create %{_datadir}/icons/hicolor || : %{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || : %postun touch --no-create %{_datadir}/icons/hicolor || : %{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || -------- %files -------- The file NEWS is useless, you can drop it as its contents refers to ChangeLog -------- Rpmlint isn't silent from srpm file: -- E: gtkpod unknown-key PGP#beaf0ce3 -- SOULDN'T: Packages must not be sign with your own key -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review