[Bug 854256] Review Request: tipcutils - Utils package required to configure TIPC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=854256

Michael Scherer <misc@xxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |misc@xxxxxxxx
             Blocks|                            |177841 (FE-NEEDSPONSOR)

--- Comment #1 from Michael Scherer <misc@xxxxxxxx> ---
Hi,

since you are not in the packager group, you need a sponsor first 
http://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group

On your spec, there is various issue with it :
- it doesn have a changelog
- you should use macro for path, rather than for well know executable

- BuildArch: x86_64  is wrong, unless there is a reason and then it should be
explained

- %{_builddir}/%{name}-%{version}/configure
you should use the macro %configure, or if it doesn't work, ./configure

- the license file should be shipped as %doc

- BuildRoot is not needed, %clean eithe,r as seen on
https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean ( the rest of the
rules are also on this page, so I recommend to read it carefully )

There is surely other stuff to fix, but I do not want to overwhelm you for the
first comment :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]