[Bug 850679] Review Request: rubygem-pdf-reader - Ruby library to parse PDF files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=850679

--- Comment #7 from Bohuslav "Slavek" Kabrda <bkabrda@xxxxxxxxxx> ---
- Building in mock results in an error:

DEBUG: + rspec spec
DEBUG: /usr/share/rubygems/rubygems/custom_require.rb:36:in `require': cannot
load such file -- minitest/unit (LoadError)

You need to BR: rubygem(minitest) to fix this. Please do mock or koji-scratch
builds before posting the spec and srpm. They can find errors like this and
will help you to go faster through the review.

- It is good to include package version in the name of the archive with specs.
This assures that when you update to newest version, rpmbuild will shout that
the archive was not found. This will remind you that you need to package newer
specs as well.

- Why exactly is the spec execution conditionalized? And why for Fedora 16 and
higher? Fedora 15 is EOLed, I see no point in that. Could you please explain
this?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]