Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xmldb-api-0.1-0.20041010.3jpp - XML:DB API for Java https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227123 ------- Additional Comments From dbhole@xxxxxxxxxx 2007-02-12 20:30 EST ------- (In reply to comment #2) > /home/fitzsim/rpmbuild/RPMS/i386/xmldb-api-javadoc-0.1-0.1.20011111cvs.1jpp.1.i386.rpm > E: xmldb-api-javadoc zero-length /usr/share/javadoc/xmldb-api-0.1/package-list > > Why is this zero-length? > That is an autogenerated file. I did not want to touch it because it will change from build to build. > - inconsistent use of %{buildroot} Fixed. > - you should use install when installing the license file Fixed. > - why are these lines needed: > > Requires(pre): jpackage-utils >= 0:1.6 > Requires(post): jpackage-utils >= 0:1.6 > Actually, that should be Requires and Requires(postun) (fixed now). /usr/share/java is owned by jpackage-utils, and because yum does not guarantee installation order with just "Requires", a requires(pre/postun) is required to ensure that no unowned dirs are left behind. New spec and srpm are in same location. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review