[Bug 844589] Review Request: perl-Devel-Declare-Parser - Higher level interface to Devel-Declare

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=844589

--- Comment #3 from Simone Caronni <negativo17@xxxxxxxxx> ---
Issues:

* Tests require perl(Test::More) and perl(Test::Exception) as patched in to
remove perl(Test::Exception::LessClever).

* There are 3 duplicates in Requires, I think you can remove the unversioned
ones; perl(B::Compiling), perl(B::Hooks::EndOfScope), perl(Devel::Declare):

$ rpm -qp --requires perl-Devel-Declare-Parser-0.017-1.fc17.noarch.rpm | uniq
-c
      1 perl(:MODULE_COMPAT_5.14.2)  
      1 perl(B::Compiling)  
      1 perl(B::Compiling) >= 0.02
      1 perl(B::Hooks::EndOfScope)  
      1 perl(B::Hooks::EndOfScope) >= 0.08
      1 perl(Carp)  
      1 perl(Data::Dumper)  
      1 perl(Devel::BeginLift)  
      1 perl(Devel::Declare)  
      1 perl(Devel::Declare) >= 0.006
      1 perl(Devel::Declare::Interface)  
      1 perl(Devel::Declare::Parser)  
      1 perl(Devel::Declare::Parser::Sublike)  
      1 perl(Exporter)  
      1 perl(Scalar::Util)  
      1 perl(base)  
      1 perl(strict)  
      1 perl(warnings)  
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1

* rpmlint issues can be ignored:

perl-Devel-Declare-Parser.src: W: spelling-error %description -l en_US parsers
-> parser, parses, parers
perl-Devel-Declare-Parser.src: W: spelling-error %description -l en_US usualy
-> usual, usually, usual y
perl-Devel-Declare-Parser.src: W: spelling-error %description -l en_US
subclassing -> sub classing, sub-classing, subclass
perl-Devel-Declare-Parser.noarch: W: spelling-error %description -l en_US
parsers -> parser, parses, parers
perl-Devel-Declare-Parser.noarch: W: spelling-error %description -l en_US
usualy -> usual, usually, usual y
perl-Devel-Declare-Parser.noarch: W: spelling-error %description -l en_US
subclassing -> sub classing, sub-classing, subclass
2 packages and 0 specfiles checked; 0 errors, 6 warnings.

* license issues as well, included README says "Standard perl license" in
COPYRIGHT section which is "GPL+ or Artistic".

[!]: MUST License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. No licenses
     found. Please check the source files for licenses manually.
See:
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#ValidLicenseShortNames
[!]: SHOULD If the source package does not include license text(s) as a
     separate file from upstream, the packager SHOULD query upstream to
     include it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]