https://bugzilla.redhat.com/show_bug.cgi?id=851747 Kevin Fenzi <kevin@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #5 from Kevin Fenzi <kevin@xxxxxxxxx> --- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License GPLv2+ OK - License field in spec matches See below - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 95c66455c02285b5f271db56479e95a631c0b21aa02b7623ac093ea20c3194fc intersection-MW1.13-37906.tar.gz 95c66455c02285b5f271db56479e95a631c0b21aa02b7623ac093ea20c3194fc intersection-MW1.13-37906.tar.gz.orig OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. Non blocking: Might ask upstream to include a copy of the License. 2. rpmlint says: mediawiki-intersection.noarch: W: spelling-error %description -l en_US bulleted -> billeted, bullet ed, bullet-ed mediawiki-intersection.noarch: W: no-documentation mediawiki-intersection.noarch: E: incorrect-fsf-address /usr/share/mediawiki/extensions/intersection/DynamicPageList.php mediawiki-intersection.src: W: spelling-error %description -l en_US bulleted -> billeted, bullet ed, bullet-ed 2 packages and 0 specfiles checked; 1 errors, 3 warnings. Might mention to upstream to correct the fsf address sometime. I see no blockers here, so this package is APPROVED. Note that for EPEL6 we will need a mediawiki119 version. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review