[Bug 852892] Review Request: ddccontrol-db - DDC/CI control database for ddccontrol

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=852892

Jaroslav Škarvada <jskarvad@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(jskarvad@redhat.c |
                   |om)                         |

--- Comment #2 from Jaroslav Škarvada <jskarvad@xxxxxxxxxx> ---
(In reply to comment #1)
Thanks for the review.

> [!]: EXTRA Spec file according to URL is the same as in SRPM.
>      Note: Spec file as given by url is not the same as in SRPM (see attached
>      diff).
> 
>      I suppose the specfile outside the SRPM is more recent. Please, confirm.
> 
Correct, I just forget to refresh the SRPM :), fixed without version bump.

> [!]: MUST License field in the package spec file matches the actual license.
> 
>      spec file states GPL+, included COPYING file is GPLv2
> 
I guess it is OK:
https://fedoraproject.org/wiki/Licensing/FAQ#How_do_I_figure_out_what_version_of_the_GPL.2FLGPL_my_package_is_under.3F

But I will ask upstream to clarify their intention.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]