https://bugzilla.redhat.com/show_bug.cgi?id=853378 --- Comment #1 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- Package Review ============== Key: - = N/A x = Pass ! = Fail ? = Not evaluated ==== Generic ==== [x]: EXTRA Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: EXTRA Spec file according to URL is the same as in SRPM. [x]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: MUST %build honors applicable compiler flags or justifies otherwise. [x]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: MUST Package contains no bundled libraries. [x]: MUST Changelog in prescribed format. [x]: MUST Sources contain only permissible code or content. [!]: MUST Each %files section contains %defattr if rpm < 4.4 Note: defattr(....) present in %files section. This is OK if packaging for EPEL5. Otherwise not needed [x]: MUST Macros in Summary, %description expandable at SRPM build time. [-]: MUST Package contains desktop file if it is a GUI application. [-]: MUST Development files must be in a -devel package [x]: MUST Package requires other packages for directories it uses. [x]: MUST Package uses nothing in %doc for runtime. [-]: MUST Package is not known to require ExcludeArch. [x]: MUST Permissions on files are set properly. [x]: MUST Package does not contain duplicates in %files. [!]: MUST Package complies to the Packaging Guidelines [x]: MUST Spec file lacks Packager, Vendor, PreReq tags. [!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf is only needed if supporting EPEL5 [-]: MUST Large documentation files are in a -doc subpackage, if required. [x]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: MUST License field in the package spec file matches the actual license. [x]: MUST Package consistently uses macro is (instead of hard-coded directory names). [x]: MUST Package is named using only allowed ascii characters. [x]: MUST Package is named according to the Package Naming Guidelines. [x]: MUST Package does not generate any conflict. [x]: MUST Package must own all directories that it creates. [x]: MUST Package does not own files or directories owned by other packages. [x]: MUST Package installs properly. [x]: MUST Package is not relocatable. [ ]: MUST Requires correct, justified where necessary. [x]: MUST Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. [x]: MUST Spec file is legible and written in American English. [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [-]: MUST Package contains systemd file(s) if in need. [x]: MUST File names are valid UTF-8. [x]: SHOULD Reviewer should test that the package builds in mock. [!]: SHOULD Buildroot is not present Note: Buildroot is not needed unless packager plans to package for EPEL5 [!]: SHOULD Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean is needed only if supporting EPEL5 [x]: SHOULD If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: SHOULD Dist tag is present. [x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [-]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [?]: SHOULD Package functions as described. [x]: SHOULD Latest version is packaged. [x]: SHOULD Package does not include license text files separate from upstream. [x]: SHOULD SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [x]: SHOULD SourceX / PatchY prefixed with %{name}. Note: Source0 (Log-Dispatch-Configurator-Any-1.110690.tar.gz) [x]: SHOULD SourceX is a working URL. [-]: SHOULD Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: SHOULD Package should compile and build into binary rpms on all supported architectures. [!]: SHOULD %check is present and all tests pass. [x]: SHOULD Packages should try to preserve timestamps of original installed files. [x]: SHOULD Spec use %global instead of %define. Rpmlint ------- Checking: perl-Log-Dispatch-Configurator-Any-1.110690-1.fc16.src.rpm perl-Log-Dispatch-Configurator-Any-1.110690-1.fc16.noarch.rpm perl-Log-Dispatch-Configurator-Any.src: W: spelling-error %description -l en_US Config -> Con fig, Con-fig, Configure perl-Log-Dispatch-Configurator-Any.src: W: non-standard-group Applications/CPAN perl-Log-Dispatch-Configurator-Any.src:31: W: setup-not-quiet perl-Log-Dispatch-Configurator-Any.src: W: invalid-url Source0: http://www.cpan.org/modules/by-module/Net/Log-Dispatch-Configurator-Any-1.110690.tar.gz HTTP Error 404: Not Found perl-Log-Dispatch-Configurator-Any.noarch: W: spelling-error %description -l en_US Config -> Con fig, Con-fig, Configure perl-Log-Dispatch-Configurator-Any.noarch: W: non-standard-group Applications/CPAN perl-Log-Dispatch-Configurator-Any.noarch: W: manifest-in-perl-module /usr/share/doc/perl-Log-Dispatch-Configurator-Any-1.110690/MANIFEST perl-Log-Dispatch-Configurator-Any.noarch: E: incorrect-fsf-address /usr/share/doc/perl-Log-Dispatch-Configurator-Any-1.110690/LICENSE 2 packages and 0 specfiles checked; 1 errors, 7 warnings. ISSUES: * Invalid source URL. It should be http://search.cpan.org/CPAN/authors/id/O/OL/OLIVER/%{perlname}-%{version}.tar.gz * Missing BuildRequires: perl(base) - lib/Log/Dispatch/Configurator/Any.pm:9 perl(Carp) - lib/Log/Dispatch/Configurator/Any.pm:11 perl(Config::Any) >= 0.15 - lib/Log/Dispatch/Configurator/Any.pm:10 pelr(Log::Dispatch::Config)- t/20-file.t:4 perl(Log::Dispatch::Configurator) - lib/Log/Dispatch/Configurator/Any.pm:9 perl(Test::More) - all tests in t/ * Optional BuildRequires for tests: perl(Config::Tiny) - t/21-not-hashref-in-file.t:8 perl(Test::Pod) >= 1.14 - t/pod.t:4 perl(Test::Pod::Coverage) >= 1.04 - t/pod-coverage.t:4 perl(YAML::Tiny) - t/20-file.t:8 * Missing Requires (listed in META.yml): perl(Config::Any) >= 0.15 perl(Log::Dispatch) >= 2.23 - there could be problem with EPEL 5. It contains 2.20. * Group should be Development/Libraries * %check is missing. Please add %check make test * Please remove README (it is same as man page), MANIFEST and META.yml from %docs * Add the option "-q" to %setup * Add "%{_fixperms} $RPM_BUILD_ROOT/*" at the end of %install section. It is not issue, if you want to build it for EPEL 5: [!]: MUST Each %files section contains %defattr if rpm < 4.4 Note: defattr(....) present in %files section. This is OK if packaging for EPEL5. Otherwise not needed [!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf is only needed if supporting EPEL5 [!]: SHOULD Buildroot is not present Note: Buildroot is not needed unless packager plans to package for EPEL5 [!]: SHOULD Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean is needed only if supporting EPEL5 Because you want to build the rpm also for EPEL 5, please fix all issue which are not related to EPEL 5. Package is NOT approved. Generated by fedora-review 0.2.0 (53cc903) last change: 2012-07-09 -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review