https://bugzilla.redhat.com/show_bug.cgi?id=837050 Jaroslav Škarvada <jskarvad@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(jskarvad@redhat.c | |om) | --- Comment #2 from Jaroslav Škarvada <jskarvad@xxxxxxxxxx> --- (In reply to comment #1) > Issues: > [!]: MUST Static libraries in -static subpackage, if present. > Note: nacl-devel-20110221-1.fc17.x86_64.rpm : /usr/lib64/libnacl.a > See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries > Probably OK, from http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries: ... There are two scenarios in which static libraries are packaged: ... 2. Static libraries only. When a package only provides static libraries you can place all the static library files in the *-devel subpackage. When doing this you also must have a virtual Provide for the *-static package: %package devel Provides: foo-static = %{version}-%{release} Packages which explicitly need to link against the static version must BuildRequire: foo-static, so that the usage can be tracked. So probably false positive/bug of fedora-review tool. > [!]: EXTRA Spec file according to URL is the same as in SRPM. > Note: Spec file as given by url is not the same as in SRPM (see attached > diff). > > > Diff spec file in url and in SRPM > --------------------------------- > --- /home/jsynacek/work/reviews/nacl.spec 2012-09-03 12:39:55.432557126 +0200 > +++ /home/jsynacek/work/reviews/nacl/srpm-unpacked/nacl.spec 2012-09-03 > 12:42:23.269591873 +0200 > @@ -1,5 +1,4 @@ > Name: nacl > -# http://nacl.cr.yp.to/ > -URL: http://nacl.cace-project.eu/ > +URL: http://nacl.cr.yp.to/ > Version: 20110221 > Release: 1%{?dist} > Requires > I fine tuned the spec URL to credit the cace-project but forget to refresh the SRPM :) It should be fixed now (I fixed it without release bump). -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review