https://bugzilla.redhat.com/show_bug.cgi?id=853784 --- Comment #1 from Martin Gieseking <martin.gieseking@xxxxxx> --- Here are a couple of initial notes: - Add a short comment above the License field explaining why we have a multiple licensing scenario here (tiled/libtiled binary: GPLv2+, tmxviewer: BSD). - Since the package doesn't provide tiled only but also tmxviewer, you should add this information to the %description (and add a final period to the sentence). - As there are no development files (headers etc.) installed, you probably don't need to provide libtiled.so either. So I recommend to remove the file and drop the devel package. - The tarball contains a copy of zlib (src/zlib). Remove this folder in %prep and ensure that Fedora's zlib is linked. - The locale files must be installed using %find_lang: https://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files Thus, add "%find_lang %{name} --with-qt" to the %install section, and append "-f %{name}.lang" to %files. Also, in the %files section, replace %{_datadir}/tiled with %{_datadir}/tiled/images/ and add the following lines for proper directory ownership: %dir %{_datadir}/tiled/ %dir %{_datadir}/tiled/translations - Always try to avoid plain asterisks in the %files section. Instead it's much better to be more specific in order to avoid adding unexpected files to the package: %{_bindir}/tiled %{_bindir}/tmxviewer %{_mandir}/man1/tiled.1* %{_mandir}/man1/tmxviewer.1* - Replace %{_libdir}/libtiled.so.1* with %{_libdir}/libtiled.so.* to simplify future updates. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review