https://bugzilla.redhat.com/show_bug.cgi?id=852174 Volker Fröhlich <volker27@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |volker27@xxxxxx --- Comment #3 from Volker Fröhlich <volker27@xxxxxx> --- Remove %clean. Use the _bindir and _includedir macro. Including COPYING multiple times is not necessary. For instance, if devel requires libs, including it in libs is enough. Your Requires should use ?_isa, as of http://fedoraproject.org/wiki/Packaging:Guidelines#Requires I'm not sure if that file should be where it is: %{_libdir}/%{name}/bin/compare-dirs Use the name macro in Source0. Remove "-n snapper-%{version}" because it's the default. Since this is no upstream release, the naming rules for snapshots apply: http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Non-Numeric_Version_in_Release Also state the exact command necessary to create the tarball. Make "%{_mandir}/man8/%{name}.*.gz" "...%{name}.*" or "...%{name}.8*". Compression might change. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review