https://bugzilla.redhat.com/show_bug.cgi?id=787510 Martin Preisler <mpreisle@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #12 from Martin Preisler <mpreisle@xxxxxxxxxx> --- Although upstream puts binary dlls and one exe into the zip archive they are not installed so I think it's not an issue except it bloats the lookaside cache. I think that including the two zero length files is OK, I would suggest that upstream puts a comment in there saying that they are "// empty for now" or something to avoid any future confusion. Regarding find $RPM_BUILD_ROOT -name '*.la' -exec rm -f {} ';' find $RPM_BUILD_ROOT -name CMakeLists.txt -exec rm -f {} ';' The first should be an option in the cmake file, the second is clearly a mistake and upstream should be notified. Nice to haves but unimportant: [!]: SHOULD Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [!]: SHOULD %check is present and all tests pass (EDIT: The latter is actually correct and I just missed it in the .spec file, sorry!) MD5-sum check ------------- http://downloads.sourceforge.net/ogl-math/glm-0.9.3.2/glm-0.9.3.2.zip : CHECKSUM(SHA256) this package : ee66ab8336b9b6b3dff69268c497688268cf5a9d2b3a14e1aa6fbd7f48c911be CHECKSUM(SHA256) upstream package : ee66ab8336b9b6b3dff69268c497688268cf5a9d2b3a14e1aa6fbd7f48c911be Approved, full review here: http://pastebin.com/yR4Sjz9Z -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review