https://bugzilla.redhat.com/show_bug.cgi?id=837988 Toshio Ernie Kuratomi <a.badger@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |a.badger@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |a.badger@xxxxxxxxx --- Comment #5 from Toshio Ernie Kuratomi <a.badger@xxxxxxxxx> --- 1f44d48d329e9a1b1d6ab72303797edf653fc1145260ff12d6463308190fce6a alembic-0.3.4.tar.gz Good: * Package naming follows the naming guidelines * License is MIT and matches in source and spec * License included as %doc * Spec file is readable * Source matches upstream * No locale files * No shared libraries * No bundled libs * Not relocatable * No files listed more than once * Macros used consistently * Code, not content * No large doc files * Doc files do not affect application at runtime * Not a GUI application * Builds in koji * Owns all directories it creates and nothing more * All filenames are utf-8 * Tested that alembic init works on F16. * No file dependencies * man pages see below Needswork: * The docs directory should be included in the packages. * Would like confirmation from upstream that python3 is something they support. Have asked Ralph on IRC and we're awaiting an answer. rpmlint: python3-alembic.noarch: W: no-manual-page-for-binary python3-alembic python-alembic.noarch: W: no-manual-page-for-binary alembic These are warnings because it's only a should. The idea is if there's man pages available somewhere we should ship them. But we're not requiring packagers to write one from scratch. Looks like debian has manpages generated by help2man. We can either utilize theirs or run help2man ourselves. http://anonscm.debian.org/viewvc/python-modules/packages/alembic/tags/0.3.4%2Bds-3/debian/alembic.1?revision=22440&view=markup&pathrev=22440 or: BuildRequires: help2man %build [...] mkdir bin echo 'python -c "import alembic.config; alembic.config.main()" $*' > bin/alembic chmod 0755 bin/*alembic help2man --version-string %{version} --no-info -s 1 bin/alembic > alembic.1 # And similar in the python3 portion: echo 'python3 -c "import alembic.config; alembic.config.main()" $*' > bin/python3-alembic chmod 0755 bin/*alembic help2man --version-string %{version} --no-info -s 1 bin/python3-alembic > python3-alembic.1 %install install -d -m 0755 %{buildroot}%{_mandir}/man1 install -m 0644 alembic.1 %{buildroot}%{_mandir}/man1/alembic.1 [...] # python3 portion install -m 0644 python3-alembic.1 %{buildroot}%{_mandir}/man1/python3-alembic.1 I prefer running help2man ourselves so that the listed version will match. python-alembic.noarch: W: spelling-error %description -l en_US http -> HTTP python-alembic.noarch: W: spelling-error %description -l en_US www -> WWW, wow You can change the case of these two if you like python-alembic.noarch: W: spelling-error %description -l en_US sqlalchemy -> alchemy This one is a false positive. Cosmetic: * In %files add a trailing slash to directories. Makes it apparent to future maintainers/random people downloading the srpm that it's intentional * This is really trivial: Summary doesn't need to begin with an article or end with punctuation. So it could be: "Database migration tool for SQLAlchemy" Notes: * Upstream has updated to 0.3.6 * I've offered to update python-sqlalchemy0.7 in EPEL6 -- waiting for an EPEL6 maintainer response -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review