Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: jflex-1.3.5-2jpp - Fast Scanner Generator https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227070 pcheung@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|pcheung@xxxxxxxxxx |mwringe@xxxxxxxxxx Flag| |fedora-review- ------- Additional Comments From pcheung@xxxxxxxxxx 2007-02-12 16:24 EST ------- MUST: * package is named appropriately * is it legal for Fedora to distribute this? * license field matches the actual license. * license is open source-compatible. * specfile name matches %{name} * verify source and patches (md5sum matches upstream, know what the patches do) * skim the summary and description for typos, etc. X correct buildroot - should be: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) * if %{?dist} is used, it should be in that form (note the ? and % locations) X license text included in package and marked with %doc COPYRIGHT missing from %doc * keep old changelog entries; use judgement when removing (too old? useless?) * packages meets FHS (http://www.pathname.com/fhs/) * rpmlint on <this package>.srpm gives no output - this is OK : W: jflex non-standard-group Development/Libraries/Java * changelog should be in one of these formats: * Fri Jun 23 2006 Jesse Keating <jkeating@xxxxxxxxxx> - 0.6-4 - And fix the link syntax. * Fri Jun 23 2006 Jesse Keating <jkeating@xxxxxxxxxx> 0.6-4 - And fix the link syntax. * Fri Jun 23 2006 Jesse Keating <jkeating@xxxxxxxxxx> - 0.6-4 - And fix the link syntax. * Packager tag should not be used * Vendor tag should not be used * use License and not Copyright * Summary tag should not end in a period * if possible, replace PreReq with Requires(pre) and/or Requires(post) X specfile is legible - Get rid of Vendor and Distribution tag - Source0 should be: http://downloads.sourceforge.net/jflex/jflex-1.3.5.tar.gz - Fix release 2jpp.1%{?dist} * package successfully compiles and builds on at least x86 * BuildRequires are proper * summary should be a short and concise description of the package * description expands upon summary (don't include installation instructions) X make sure lines are <= 80 characters line 89 is longer than 80 characters * specfile written in American English * make a -doc sub-package if necessary * packages including libraries should exclude static libraries if possible * don't use rpath * config files should usually be marked with %config(noreplace) * GUI apps should contain .desktop files * should the package contain a -devel sub-package? * use macros appropriately and consistently * don't use %makeinstall * locale data handling correct (find_lang) - if translations included, add BR: gettext and use %find_lang %{name} at the end of %install * consider using cp -p to preserve timestamps * split Requires(pre,post) into two separate lines * package should probably not be relocatable * package contains code * package should own all directories and files * there should be no %files duplicates * file permissions should be okay; %defattrs should be present * %clean should be present * %doc files should not affect runtime * if it is a web apps, it should be in /usr/share/%{name} and *not* /var/www * verify the final provides and requires of the binary RPMs [pcheung@topcat ~]$ rpm -qpl --provides /home/pcheung/topdir/RPMS/noarch/jflex-1.3.5-2jpp.noarch.rpm jflex = 0:1.3.5-2jpp /usr/share/doc/jflex-1.3.5 /usr/share/doc/jflex-1.3.5/COPYRIGHT /usr/share/doc/jflex-1.3.5/faq.html /usr/share/doc/jflex-1.3.5/foot_motif.gif /usr/share/doc/jflex-1.3.5/jflex_anttask.html /usr/share/doc/jflex-1.3.5/logo.gif /usr/share/doc/jflex-1.3.5/manual.css /usr/share/doc/jflex-1.3.5/manual.html /usr/share/doc/jflex-1.3.5/manual.pdf /usr/share/doc/jflex-1.3.5/manual.ps.gz /usr/share/java/jflex-1.3.5.jar /usr/share/java/jflex.jar [pcheung@topcat ~]$ rpm -qpl --requires /home/pcheung/topdir/RPMS/noarch/jflex-1.3.5-2jpp.noarch.rpm rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 /usr/share/doc/jflex-1.3.5 /usr/share/doc/jflex-1.3.5/COPYRIGHT /usr/share/doc/jflex-1.3.5/faq.html /usr/share/doc/jflex-1.3.5/foot_motif.gif /usr/share/doc/jflex-1.3.5/jflex_anttask.html /usr/share/doc/jflex-1.3.5/logo.gif /usr/share/doc/jflex-1.3.5/manual.css /usr/share/doc/jflex-1.3.5/manual.html /usr/share/doc/jflex-1.3.5/manual.pdf /usr/share/doc/jflex-1.3.5/manual.ps.gz /usr/share/java/jflex-1.3.5.jar /usr/share/java/jflex.jar [pcheung@topcat ~]$ rpm -qpl --provides /home/pcheung/topdir/RPMS/noarch/jflex-javadoc-1.3.5-2jpp.noarch.rpm jflex-javadoc = 0:1.3.5-2jpp /usr/share/javadoc/jflex-1.3.5 /usr/share/javadoc/jflex-1.3.5/JFlex /usr/share/javadoc/jflex-1.3.5/JFlex/Action.html /usr/share/javadoc/jflex-1.3.5/JFlex/CharClassException.html /usr/share/javadoc/jflex-1.3.5/JFlex/CharClassIntervall.html /usr/share/javadoc/jflex-1.3.5/JFlex/CharClasses.html /usr/share/javadoc/jflex-1.3.5/JFlex/CharSet.html /usr/share/javadoc/jflex-1.3.5/JFlex/CharSetEnumerator.html /usr/share/javadoc/jflex-1.3.5/JFlex/DFA.html /usr/share/javadoc/jflex-1.3.5/JFlex/EOFActions.html /usr/share/javadoc/jflex-1.3.5/JFlex/Emitter.html /usr/share/javadoc/jflex-1.3.5/JFlex/ErrorMessages.html /usr/share/javadoc/jflex-1.3.5/JFlex/GeneratorException.html /usr/share/javadoc/jflex-1.3.5/JFlex/IntCharSet.html /usr/share/javadoc/jflex-1.3.5/JFlex/Intervall.html /usr/share/javadoc/jflex-1.3.5/JFlex/LexParse.html /usr/share/javadoc/jflex-1.3.5/JFlex/LexScan.html /usr/share/javadoc/jflex-1.3.5/JFlex/LexicalStates.html /usr/share/javadoc/jflex-1.3.5/JFlex/MacroException.html /usr/share/javadoc/jflex-1.3.5/JFlex/Macros.html /usr/share/javadoc/jflex-1.3.5/JFlex/Main.html /usr/share/javadoc/jflex-1.3.5/JFlex/NFA.html /usr/share/javadoc/jflex-1.3.5/JFlex/Out.html /usr/share/javadoc/jflex-1.3.5/JFlex/RegExp.html /usr/share/javadoc/jflex-1.3.5/JFlex/RegExp1.html /usr/share/javadoc/jflex-1.3.5/JFlex/RegExp2.html /usr/share/javadoc/jflex-1.3.5/JFlex/RegExps.html /usr/share/javadoc/jflex-1.3.5/JFlex/ScannerException.html /usr/share/javadoc/jflex-1.3.5/JFlex/SemCheck.html /usr/share/javadoc/jflex-1.3.5/JFlex/Skeleton.html /usr/share/javadoc/jflex-1.3.5/JFlex/StatePairList.html /usr/share/javadoc/jflex-1.3.5/JFlex/StateSet.html /usr/share/javadoc/jflex-1.3.5/JFlex/StateSetEnumerator.html /usr/share/javadoc/jflex-1.3.5/JFlex/StdOutWriter.html /usr/share/javadoc/jflex-1.3.5/JFlex/Timer.html /usr/share/javadoc/jflex-1.3.5/JFlex/package-frame.html /usr/share/javadoc/jflex-1.3.5/JFlex/package-summary.html /usr/share/javadoc/jflex-1.3.5/JFlex/package-tree.html /usr/share/javadoc/jflex-1.3.5/JFlex/sym.html /usr/share/javadoc/jflex-1.3.5/allclasses-frame.html /usr/share/javadoc/jflex-1.3.5/allclasses-noframe.html /usr/share/javadoc/jflex-1.3.5/constant-values.html /usr/share/javadoc/jflex-1.3.5/deprecated-list.html /usr/share/javadoc/jflex-1.3.5/help-doc.html /usr/share/javadoc/jflex-1.3.5/index-all.html /usr/share/javadoc/jflex-1.3.5/index.html /usr/share/javadoc/jflex-1.3.5/overview-tree.html /usr/share/javadoc/jflex-1.3.5/package-list /usr/share/javadoc/jflex-1.3.5/packages.html /usr/share/javadoc/jflex-1.3.5/resources /usr/share/javadoc/jflex-1.3.5/resources/inherit.gif /usr/share/javadoc/jflex-1.3.5/serialized-form.html /usr/share/javadoc/jflex-1.3.5/stylesheet.css [pcheung@topcat ~]$ rpm -qpl --requires /home/pcheung/topdir/RPMS/noarch/jflex-javadoc-1.3.5-2jpp.noarch.rpm /bin/sh /bin/sh rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 /usr/share/javadoc/jflex-1.3.5 /usr/share/javadoc/jflex-1.3.5/JFlex /usr/share/javadoc/jflex-1.3.5/JFlex/Action.html /usr/share/javadoc/jflex-1.3.5/JFlex/CharClassException.html /usr/share/javadoc/jflex-1.3.5/JFlex/CharClassIntervall.html /usr/share/javadoc/jflex-1.3.5/JFlex/CharClasses.html /usr/share/javadoc/jflex-1.3.5/JFlex/CharSet.html /usr/share/javadoc/jflex-1.3.5/JFlex/CharSetEnumerator.html /usr/share/javadoc/jflex-1.3.5/JFlex/DFA.html /usr/share/javadoc/jflex-1.3.5/JFlex/EOFActions.html /usr/share/javadoc/jflex-1.3.5/JFlex/Emitter.html /usr/share/javadoc/jflex-1.3.5/JFlex/ErrorMessages.html /usr/share/javadoc/jflex-1.3.5/JFlex/GeneratorException.html /usr/share/javadoc/jflex-1.3.5/JFlex/IntCharSet.html /usr/share/javadoc/jflex-1.3.5/JFlex/Intervall.html /usr/share/javadoc/jflex-1.3.5/JFlex/LexParse.html /usr/share/javadoc/jflex-1.3.5/JFlex/LexScan.html /usr/share/javadoc/jflex-1.3.5/JFlex/LexicalStates.html /usr/share/javadoc/jflex-1.3.5/JFlex/MacroException.html /usr/share/javadoc/jflex-1.3.5/JFlex/Macros.html /usr/share/javadoc/jflex-1.3.5/JFlex/Main.html /usr/share/javadoc/jflex-1.3.5/JFlex/NFA.html /usr/share/javadoc/jflex-1.3.5/JFlex/Out.html /usr/share/javadoc/jflex-1.3.5/JFlex/RegExp.html /usr/share/javadoc/jflex-1.3.5/JFlex/RegExp1.html /usr/share/javadoc/jflex-1.3.5/JFlex/RegExp2.html /usr/share/javadoc/jflex-1.3.5/JFlex/RegExps.html /usr/share/javadoc/jflex-1.3.5/JFlex/ScannerException.html /usr/share/javadoc/jflex-1.3.5/JFlex/SemCheck.html /usr/share/javadoc/jflex-1.3.5/JFlex/Skeleton.html /usr/share/javadoc/jflex-1.3.5/JFlex/StatePairList.html /usr/share/javadoc/jflex-1.3.5/JFlex/StateSet.html /usr/share/javadoc/jflex-1.3.5/JFlex/StateSetEnumerator.html /usr/share/javadoc/jflex-1.3.5/JFlex/StdOutWriter.html /usr/share/javadoc/jflex-1.3.5/JFlex/Timer.html /usr/share/javadoc/jflex-1.3.5/JFlex/package-frame.html /usr/share/javadoc/jflex-1.3.5/JFlex/package-summary.html /usr/share/javadoc/jflex-1.3.5/JFlex/package-tree.html /usr/share/javadoc/jflex-1.3.5/JFlex/sym.html /usr/share/javadoc/jflex-1.3.5/allclasses-frame.html /usr/share/javadoc/jflex-1.3.5/allclasses-noframe.html /usr/share/javadoc/jflex-1.3.5/constant-values.html /usr/share/javadoc/jflex-1.3.5/deprecated-list.html /usr/share/javadoc/jflex-1.3.5/help-doc.html /usr/share/javadoc/jflex-1.3.5/index-all.html /usr/share/javadoc/jflex-1.3.5/index.html /usr/share/javadoc/jflex-1.3.5/overview-tree.html /usr/share/javadoc/jflex-1.3.5/package-list /usr/share/javadoc/jflex-1.3.5/packages.html /usr/share/javadoc/jflex-1.3.5/resources /usr/share/javadoc/jflex-1.3.5/resources/inherit.gif /usr/share/javadoc/jflex-1.3.5/serialized-form.html /usr/share/javadoc/jflex-1.3.5/stylesheet.css * run rpmlint on the binary RPMs W: jflex non-standard-group Development/Libraries/Java W: jflex wrong-file-end-of-line-encoding /usr/share/doc/jflex-1.3.5/COPYRIGHT W: jflex uncompressed-zip /usr/share/java/jflex-1.3.5.jar W: jflex-javadoc non-standard-group Development/Documentation W: jflex-javadoc dangerous-command-in-%post rm W: jflex-javadoc dangerous-command-in-%postun rm SHOULD: * package should include license text in the package and mark it with %doc * package should build on i386 built on i386 * package should build in mock i don't have mock set up yet -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review