[Bug 806037] Review Request: pygrib - Python module for reading and writing GRIB (editions 1 and 2) files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=806037

--- Comment #6 from Jos de Kloe <josdekloe@xxxxxxxxx> ---
new versions of the SRPM and SPEC file are here:

Spec URL: http://jdekloe.nl/Fedora/pygrib.spec
SRPM URL: http://jdekloe.nl/Fedora/pygrib-1.9.4-2.fc17.src.rpm

@Thomas:
> Don't own %{python_sitearch}/ directly. Just the files below it.
> Please be a bit more specific for %{_bindir}/*

both have been made more specific.

> Building seems to be somehow wrong (Just had a brief look...):
> import pygrib
> ImportError: ./pygrib.so: undefined symbol: grib_index_write
>
>  Did you check, if this program works, when installed?

As said above the module does work on Rawhide.
On Fedora17 it fails because pyproj cannot be build.
pyproj in turn needs proj v4.8.0 which is not yet available for Fedora17, which
only is at proj v4.7.0 at the moment.
As soon as proj gets updated to 4.8.0 I'll try to get pygrib to build on
Fedora17 as well.

@Volker:

>grib_index_write was only defined in version 1.9 of the grib_api. As far as I >can see, we have 1.7 in Fedora.

current grib_api in Fedora17 has been updated to v1.9.16 so this is not a
problem anymore.

>Did you not specify 'export OPENJPEG_DIR="%{_usr}/"' for a reason? Also BR >openjpeg-devel if you decide to do so.

Yes this has a reason. By applying "trial-and-error" I tried to find a minimal
amount of enviroment settings needed to build the package. I found that
defining JASPER_DIR and PNG_DIR is sufficient.
I also found that OPENJPEG_DIR should NOT be specified. The build fails if it
is added.

> "%{__python} setup.py build" is enough. The flags are used anyway.

thanks. I removed the flags.

> You must require the -static provides for g2clib and grib_api.

this has been added as well.

> (There's a typo in "pre-coocked".)

thanks, fixed it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]