https://bugzilla.redhat.com/show_bug.cgi?id=852623 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- Source tar ball is original (SHA-256: 7d439d7a6e71f7d25daba6436f0a268e06b02572b23cf1f3745f57a8bef159a0). Ok. Source0 and URL are usable. Ok. Summary verified from Catalog.pm. Ok. License verified from Catalog.pm. Ok. TODO: Add the first sentence from Catalog POD description. Alternatively points to the standard (https://www.oasis-open.org/committees/entity/specs/cs-entity-xml-catalogs-1.0.html). It explains what this package does. TODO: Replace variable PERL_INSTALL_ROOT obsoleted with DESTDIR name in %install. TODO: Remove the deleting empty directories in %install section. This is default behavior. No XS code, noarch BuildArch is Ok. Build-requires are Ok. All tests pass. Ok. $ rpmlint perl-XML-Catalog.spec ../SRPMS/perl-XML-Catalog-0.02-1.fc19.src.rpm ../RPMS/noarch/perl-XML-Catalog-0.02-1.fc19.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-XML-Catalog-0.02-1.fc19.noarch.rpm drwxr-xr-x 2 root root 0 Aug 29 14:17 /usr/share/doc/perl-XML-Catalog-0.02 -rw-r--r-- 1 root root 257 Aug 29 14:17 /usr/share/doc/perl-XML-Catalog-0.02/Changes -rw-r--r-- 1 root root 1027 Aug 29 14:17 /usr/share/doc/perl-XML-Catalog-0.02/README -rw-r--r-- 1 root root 2940 Aug 29 14:17 /usr/share/man/man3/XML::Catalog.3pm.gz drwxr-xr-x 2 root root 0 Aug 29 14:17 /usr/share/perl5/vendor_perl/XML -rw-r--r-- 1 root root 9730 Sep 21 2000 /usr/share/perl5/vendor_perl/XML/Catalog.pm File permissions and layout are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-XML-Catalog-0.02-1.fc19.noarch.rpm |sort |uniq -c 1 perl(LWP::Simple) 1 perl(:MODULE_COMPAT_5.16.1) 1 perl(strict) 1 perl(Text::ParseWords) 1 perl(URI::URL) 1 perl(vars) 1 perl(XML::Parser) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-XML-Catalog-0.02-1.fc19.noarch.rpm |sort |uniq -c 1 perl(XML::Catalog) = 0.02 1 perl-XML-Catalog = 0.02-1.fc19 1 perl(XML::Catalog::XML) Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-XML-Catalog-0.02-1.fc19.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F19 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4434159). Ok. Package is in line with Fedora and Perl packaging guidelines. Please consider fixing all `TODO' items before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review