https://bugzilla.redhat.com/show_bug.cgi?id=851859 --- Comment #8 from Martin Gieseking <martin.gieseking@xxxxxx> --- Here comes the formal review of your package. There are some minor things left that could be fixed easily. If you don't have a sponsor yet, I can sponsor you if you're willing to do a couple of informal reviews (aka simulated package reviews). Since you're allowed to review and approve packages of other packagers once you're a member of the packager group, it's important to practice the review procedure a bit. For further information let's email privately. Summary of the review results: - Replace "Opensource" with "Open source". - In the %changelog, replace the single percent signs with double ones to make rpmlint happy. - The incorrect FSF addresses in the source files mentioned below should be fixed upstream. That's not a blocker, though. - Drop "%{buildroot}/" from the rm statement in %prep. All paths are relative to the root of decompressed tarball. rm -rf %{buildroot}/libs/enet => rm -rf libs/enet - There's a manpage (mana.6) present in docs/. It should be installed properly in order to make use of it: * add the following lines to the %install section: install -D -p -m664 docs/%{name}.6 %{buildroot}/%{_mandir}/man6/%{name}.6 rm -f docs/%{name}.6 * add %{_mandir}/man6/%{name}.6* to %files - Macros/Variables must be used consistently, so don't mix $RPM_BUILD_ROOT and %{buildroot}. Choose one variant and stick with it. => replace $RPM_BUILD_ROOT with %{buildroot} ------------------------------ $ rpmlint *.rpm mana.i686: W: spelling-error Summary(en_US) Opensource -> Open source, Open-source, Outsource mana.i686: W: spelling-error %description -l en_US eAthena -> Athena, e Athena, heathen mana.i686: W: spelling-error %description -l en_US tmwAthena -> Athena mana.i686: W: dangling-symlink /usr/share/mana/data/fonts/dejavusans-bold.ttf /usr/share/fonts/dejavu/DejaVuSans-Bold.ttf mana.i686: W: dangling-symlink /usr/share/mana/data/fonts/dejavusans-mono.ttf /usr/share/fonts/dejavu/DejaVuSansMono.ttf mana.i686: W: dangling-symlink /usr/share/mana/data/fonts/dejavusans.ttf /usr/share/fonts/dejavu/DejaVuSans.ttf mana.i686: W: no-manual-page-for-binary mana mana.src: W: spelling-error Summary(en_US) Opensource -> Open source, Open-source, Outsource mana.src: W: spelling-error %description -l en_US eAthena -> Athena, e Athena, heathen mana.src: W: spelling-error %description -l en_US tmwAthena -> Athena mana.src:59: W: rpm-buildroot-usage %prep rm -rf %{buildroot}/libs/enet mana.src:89: W: macro-in-%changelog %{mana} mana.src:91: W: macro-in-%changelog %{optflags} mana.src:94: W: macro-in-%changelog %cmake mana.src:98: W: macro-in-%changelog %{name} mana.src:99: W: macro-in-%changelog %defattr mana-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/mana-0.6.1/src/gui/textpopup.h mana-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/mana-0.6.1/src/chatlogger.h mana-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/mana-0.6.1/src/gui/textpopup.cpp mana-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/mana-0.6.1/src/chatlogger.cpp 3 packages and 0 specfiles checked; 4 errors, 16 warnings. - dangling symlinks are expected and OK here --------------------------------- key: [+] OK [.] OK, not applicable [X] needs work --------------------------------- [+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name}. [+] MUST: The package must meet the Packaging Guidelines. [+] MUST: The package must be licensed with a Fedora approved license. GPLv2+ according to source file headers [+] MUST: The License field in the package spec file must match the actual license. [+] MUST: The file containing the text of the license(s) for the package must be included in %doc. [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source. $ sha256sum mana-0.6.1.tar.gz* b945cd3e32489dfa5b8e82d571cc11e0e5308576307fca4d8dd7cf3cf6ed8c55 mana-0.6.1.tar.gz b945cd3e32489dfa5b8e82d571cc11e0e5308576307fca4d8dd7cf3cf6ed8c55 mana-0.6.1.tar.gz.upstream [+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. [.] MUST: If the package does not successfully compile, ... [+] MUST: All build dependencies must be listed in BuildRequires. [+] MUST: When compiling C, C++, or Fortran files, %{optflags} must be applied. [+] MUST: The spec file MUST handle locales properly. [.] MUST: If a package installs files below %{_datadir}/icons, the icon cache must be updated. [.] MUST: Packages storing shared library files (not just symlinks) must call ldconfig in %post and %postun. [+] MUST: Packages must NOT bundle copies of system libraries. [.] MUST: If the package is designed to be relocatable, ... [+] MUST: A package must own all directories that it creates. [+] MUST: A Fedora package must not list a file more than once in %files. [+] MUST: Permissions on files must be set properly. [X] MUST: Each package must consistently use macros. - replace $RPM_BUILD_ROOT with %{buildroot} [+] MUST: The package must contain code, or permissable content. [.] MUST: Large documentation files must go in a -doc subpackage. [+] MUST: Files in %doc must not affect the runtime of the application. [.] MUST: Header files must be in a -devel package. [.] MUST: Static libraries must be in a -static package. [.] MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), ... [.] MUST: devel packages must require the base package using a fully versioned dependency. [+] MUST: Packages must NOT contain any .la libtool archives. [+] MUST: Packages containing GUI applications must include a %{name}.desktop file. [+] MUST: .desktop files must be properly installed with desktop-file-install in the %install section. [+] MUST: Packages must not own files or directories already owned by other packages. [+] MUST: All filenames in rpm packages must be valid UTF-8. [.] SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [+] SHOULD: Timestamps of files should be preserved. [+] SHOULD: Patch files should be prefixed with %{name}- [+] SHOULD: All patches should be commented in the spec file [+] SHOULD: The reviewer should test that the package builds in mock. [+] SHOULD: The reviewer should test that the package functions as described. [.] SHOULD: If scriptlets are used, those scriptlets must be sane. [.] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. [.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg. [+] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself. [X] SHOULD: Your package should contain man pages for binaries/scripts. - manpage docs/mana.6 not installed properly -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review