https://bugzilla.redhat.com/show_bug.cgi?id=847419 Michael Scherer <misc@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misc@xxxxxxxx --- Comment #17 from Michael Scherer <misc@xxxxxxxx> --- The review didn't catch some issues : the same multiple license issues problem as others, I will not repeat what i said in others bug reports : https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensing_Scenarios in fact, looking at it, there is no GPL licensed code in the tarball, except ltmain.sh, which is part of the build system and so do not count in distribution. So the license tag is wrong, and the reviewer should have caught that. There is also the fact that the desktop file is not checked explicitly : https://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage The Buildrequires are also likely wrong, since there is no need for cairo there ( that's a polkit agent in gtk2 ), and there is surely a bug somewhere else. Removing it make build fails, and while adding it is a work around, that's likely not the right fix since nothing in the source code requires cairo, and the real fix should be to report this to the maintainer of the gtk package so it requires what is needed instead. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review