https://bugzilla.redhat.com/show_bug.cgi?id=847604 Michael Scherer <misc@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misc@xxxxxxxx --- Comment #14 from Michael Scherer <misc@xxxxxxxx> --- Rex, the review have been rather hasty, you missed some points like : https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensing_Scenarios I see no license clarification in the spec file as committed in git. This should be fixed ASAP, given that Fedora try to be as clean as possible from a legal point of view ( and I guess Dan do not want to have Legal involved in the feature ). %{_datadir}/libmatekbd/ui/show-layout.ui this directory end being unowned, this is a violation of https://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_wholly_contained_in_your_package.2C_or_involves_core_functionality_of_your_package - the desktop file modification are likely wrong, since mate is a registered environment : http://standards.freedesktop.org/menu-spec/latest/apb.html So if mate do not show "mate" category desktop file, a bug report should be filled, or at least, it should be explained and investigated. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review